From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id BE43321F14B for ; Mon, 21 Jan 2013 07:36:31 -0800 (PST) Received: by mail-wg0-f47.google.com with SMTP id dq11so801177wgb.2 for ; Mon, 21 Jan 2013 07:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=fVW9FcqfOmHgrAX74jusei8Iju17mHoUUMTaHa9LtY4=; b=GjyHRrM3vmwjU4FzsKUc8Z20l/CJt3GXm7qjs+wWvMVEIyElw9lgZc7FPHIgjOxrYy 4Z4B/DECFW775PiqbrVozMcvAd3oRPo1pn89Z9J5/llnZch4MgF5PxDH3QSqlkpPzxJL V6GCkpkuJBVS3zc5xSqzYmRtsMp8MqOM4OBZ3ErkvRIS6q9guY5dBGjvu21JGqDh5zjS fY/7LYinWx3x724ccV+1u1G1mFq2xJx3R3lNc5HhFaQer28ENxFAKmP5U/MqBLJcZBRW hCq4L33HBghAnYnG56yVZtawT7M7e4+KrU2YUjHUc2y6dlmgSZG/+rrxJ0QolGljya79 F6FA== MIME-Version: 1.0 X-Received: by 10.180.78.137 with SMTP id b9mr16118225wix.30.1358782589442; Mon, 21 Jan 2013 07:36:29 -0800 (PST) Received: by 10.194.88.197 with HTTP; Mon, 21 Jan 2013 07:36:29 -0800 (PST) In-Reply-To: References: Date: Mon, 21 Jan 2013 15:36:29 +0000 Message-ID: From: Robert Bradley To: Ketan Kulkarni Content-Type: multipart/alternative; boundary=f46d0435c03c921bc804d3ce3954 Cc: cerowrt-devel Subject: Re: [Cerowrt-devel] was filled with hope for killing the last traps, now have brick X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2013 15:36:32 -0000 --f46d0435c03c921bc804d3ce3954 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable You're right; it should indeed be "net_hdr_word(&addr[fn_bit >> 5]);". That's my fault for not checking the patches thoroughly enough. I'm more than a bit surprised the compiler accepted that code as-is... On 21 January 2013 13:50, Ketan Kulkarni wrote: > Looking at the patch - > > - addr[fn_bit >> 5]; > + net_hdr_word(addr[fn_bit >> 5]); > > Should the above line be - (& missing in the above line??) > > + net_hdr_word(&addr[fn_bit >> 5]); > > -Ketan > > On Mon, Jan 21, 2013 at 6:51 PM, Ketan Kulkarni > wrote: > > Well with this 3.7.3-1, I didnt see any crashes. I didnt change any > > default config. > > The router boots up well (in fact writing this mail through the same) > > I also note I use IPv4 network only. > > > > I collected dmesg after booting up and kept here (in case required) - > > http://pastebin.com/p1aM1aV8 > > > > -Ketan > > > > > > On Mon, Jan 21, 2013 at 2:31 PM, Dave Taht wrote: > >> A build without that patch is now up here: > >> > >> http://snapon.lab.bufferbloat.net/~cero2/cerowrt/wndr/3.7.3-1/ > >> > >> so 1/3 of the potential causes is not there.... > >> > >> On Mon, Jan 21, 2013 at 3:51 AM, Ketan Kulkarni > wrote: > >>> > >>> Hi Dave, > >>> Probably I can take a look later tonight by having serial cable - I > >>> have that one handy. > >>> What is the build and how to re-create the scenario? > >>> > >> > >> Well, I hate to commit sources when stuff is obviously borked. If you > >> want to try flashing with that you can figure out if it was us or the > merge > >> that went bad.... > >> > >> > >> > >> > >>> > >>> Thanks, > >>> Ketan > >>> > >>> > >>> On Mon, Jan 21, 2013 at 12:54 AM, Dave Taht > wrote: > >>> > Mine and Robert Bradley's latest attempt at killing the last ipv6 > >>> > instruction traps > >>> > with a rollup patch from bugs 419 and 421... > >>> > > >>> > brick the router. It boots, the main green light goes on, then it > dies. > >>> > Naturally > >>> > I left the serial cable at the office... > >>> > > >>> > Of course in the middle of this patch set revision I also updated t= o > >>> > 3.7.3 > >>> > and openwrt head, > >>> > so have a few more variables than usual than just us to cope with. > >>> > > >>> > I would not mind eyeballs on this to see if there is an obvious fla= w, > >>> > otherwise I will progressively bisect from what was known to work > >>> > forward as fast as I can. (besides, the hope is to submit this > >>> > upstream) > >>> > > >>> > net_hdr_word is defined in the 902-unaligned_access_hacks patch in > >>> > openwrt > >>> > head... > >>> > > >>> > now off to find a small, sharp, pointy object... > >>> > > >>> > -- > >>> > Dave T=C3=A4ht > >>> > > >>> > Fixing bufferbloat with cerowrt: > >>> > http://www.teklibre.com/cerowrt/subscribe.html > >>> > > >>> > _______________________________________________ > >>> > Cerowrt-devel mailing list > >>> > Cerowrt-devel@lists.bufferbloat.net > >>> > https://lists.bufferbloat.net/listinfo/cerowrt-devel > >>> > > >> > >> > >> > >> > >> -- > >> Dave T=C3=A4ht > >> > >> Fixing bufferbloat with cerowrt: > >> http://www.teklibre.com/cerowrt/subscribe.html > --=20 Robert Bradley --f46d0435c03c921bc804d3ce3954 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
You're right; it should indeed be "net_hdr_word(&= amp;addr[fn_bit >> 5]);".=C2=A0 That's my fault for not chec= king the patches thoroughly enough.=C2=A0 I'm more than a bit surprised= the compiler accepted that code as-is...


On 21 J= anuary 2013 13:50, Ketan Kulkarni <ketkulka@gmail.com> wrot= e:
Looking at the patch -

- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr[fn_bit >> 5];<= br> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0net_hdr_word(addr[fn_bit = >> 5]);

Should the above line be - (& missing in the above line??)

+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0net_hdr_word(&addr[fn= _bit >> 5]);

-Ketan

On Mon, Jan 21, 2013 at 6:51 PM, Ketan Kulkarni <ketkulka@gmail.com> wrote:
> Well with this 3.7.3-1, I didnt see any crashes. I didnt change any > default config.
> The router boots up well (in fact writing this mail through the same)<= br> > I also note I use IPv4 network only.
>
> I collected dmesg after booting up and kept here (in case required) -<= br> > http://past= ebin.com/p1aM1aV8
>
> -Ketan
>
>
> On Mon, Jan 21, 2013 at 2:31 PM, Dave Taht <dave.taht@gmail.com> wrote:
>> A build without that patch is now up here:
>>
>> http://snapon.lab.bufferbloat.net/~cero2/cerowrt= /wndr/3.7.3-1/
>>
>> so 1/3 of the potential causes is not there....
>>
>> On Mon, Jan 21, 2013 at 3:51 AM, Ketan Kulkarni <ketkulka@gmail.com> wrote:
>>>
>>> Hi Dave,
>>> Probably I can take a look later tonight by having serial cabl= e - I
>>> have that one handy.
>>> What is the build and how to re-create the scenario?
>>>
>>
>> Well, I hate to commit sources when stuff is obviously borked. If = you
>> want to try flashing with that you can figure out if it was us or = the merge
>> that went bad....
>>
>>
>>
>>
>>>
>>> Thanks,
>>> Ketan
>>>
>>>
>>> On Mon, Jan 21, 2013 at 12:54 AM, Dave Taht <dave.taht@gmail.com> wrote:
>>> > Mine and Robert Bradley's latest attempt at killing t= he last ipv6
>>> > instruction traps
>>> > with a rollup patch from bugs 419 and 421...
>>> >
>>> > brick the router. It boots, the main green light goes on,= then it dies.
>>> > Naturally
>>> > I left the serial cable at the office...
>>> >
>>> > Of course in the middle of this patch set revision I also= updated to
>>> > 3.7.3
>>> > and openwrt head,
>>> > so have a few more variables than usual than just us to c= ope with.
>>> >
>>> > I would not mind eyeballs on this to see if there is an o= bvious flaw,
>>> > otherwise I will progressively bisect from what was known= to work
>>> > forward as fast as I can. (besides, the hope is to =C2=A0= submit this
>>> > upstream)
>>> >
>>> > net_hdr_word is defined in the 902-unaligned_access_hacks= patch in
>>> > openwrt
>>> > head...
>>> >
>>> > now off to find a small, sharp, pointy object...
>>> >
>>> > --
>>> > Dave T=C3=A4ht
>>> >
>>> > Fixing bufferbloat with cerowrt:
>>> > http://www.teklibre.com/cerowrt/subscribe.html
>>> >
>>> > _______________________________________________
>>> > Cerowrt-devel mailing list
>>> > Ce= rowrt-devel@lists.bufferbloat.net
>>> > https://lists.bufferbloat.net/listinfo/cerowrt-de= vel
>>> >
>>
>>
>>
>>
>> --
>> Dave T=C3=A4ht
>>
>> Fixing bufferbloat with cerowrt:
>> http://www.teklibre.com/cerowrt/subscribe.html



--
Robert Brad= ley
--f46d0435c03c921bc804d3ce3954--