From: Jonathan Morton <chromatix99@gmail.com>
To: Alan Jenkins <alan.christopher.jenkins@gmail.com>
Cc: cake@lists.bufferbloat.net,
cerowrt-devel <cerowrt-devel@lists.bufferbloat.net>
Subject: Re: [Cerowrt-devel] Latest build test - new sqm-scripts seem to work; "cake overhead 40" [still] didn't
Date: Sat, 20 Jun 2015 15:46:33 +0300 [thread overview]
Message-ID: <CAJq5cE1Wzhcg76txR78dHv2gsV9ZvKku-PyKoX7z97M2uhxAxQ@mail.gmail.com> (raw)
In-Reply-To: <5585545B.6040108@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
It looks like your cake is new enough to support set associative hashing,
but not the new overhead handling. The ATM flag was put in a long time ago.
Looking at the code which grabs those options (cake_change), there doesn't
seem to be a way to detect whether an unsupported option was provided by
userspace, unless nla_parse_nested returns an error if the provided option
struct would be overflowed. Clearly it doesn't, but just truncates it to
fit.
- Jonathan Morton
[-- Attachment #2: Type: text/html, Size: 538 bytes --]
next prev parent reply other threads:[~2015-06-20 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 10:55 Alan Jenkins
2015-06-20 11:00 ` Jonathan Morton
2015-06-20 11:54 ` Alan Jenkins
2015-06-20 12:46 ` Jonathan Morton [this message]
2015-06-20 12:48 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cerowrt-devel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJq5cE1Wzhcg76txR78dHv2gsV9ZvKku-PyKoX7z97M2uhxAxQ@mail.gmail.com \
--to=chromatix99@gmail.com \
--cc=alan.christopher.jenkins@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=cerowrt-devel@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox