From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa0-f46.google.com (mail-oa0-f46.google.com [209.85.219.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 6879521F115 for ; Sun, 13 Jan 2013 16:38:59 -0800 (PST) Received: by mail-oa0-f46.google.com with SMTP id h16so3513617oag.33 for ; Sun, 13 Jan 2013 16:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=azix90AkPf5o0o5B28eHPCZeYcQmBna2AmCgV7vR5F4=; b=kyxQcbKRw8IA2+YCrpyD0T3QmKxZa6AUknssSlDEMbXy47NnTsh5WQnKlOSSONTMk2 sbNgMWj7Fy4qDSOn7eveXL8T0ZA1QQgU1XOofkZ6X0YoFvtcVZiIVoVuQIjrLUjAPR4P KjAvdC0JEZIOp+hGj4D5HmtT4JxPQJkR0+y5gpIUel+X0/FlbSuW27gOxBpK6CZcXSKd VXpZXxfjvf/59+fTDm0UQuyQ4qqa7AfBmqcMHBp+Sr5zfKowc+6NRGZyNgbsqq6A5LuL q/D1fow5uBt0hdRgWrQmwqXNsqxSjaqEzKTQgYRhqEpPhgBtpN8IIr5EpU5LWMTn5tu5 laog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=azix90AkPf5o0o5B28eHPCZeYcQmBna2AmCgV7vR5F4=; b=YN7+xFxgEK5c4HID/DoYrhw7PEcI+NNJ5HHPSAQ+nmBjMSj1XeOROiMfwebxmCV6c2 DJeslcBKEv0N97SSwBnKH5tyUWrDEEI+xD+YUsoM+KKihI1XSdtR8Rb2AiGu0KI3cLGu HzLR4xrTsukzEuYmAUn4s3TMqKteWE35aussP3i7Miv4UwFzeMpySp1CHBY0m+CR0ukr hrus5bGZOpeDEPEoJQBrzWwLsF2ubKKdrbShlZ4l/Azg8I2f7wFhDr5AvOYWbnHzM1V8 8iYsL3SQRVDCxD1CjK1f7TNB3KWchH6htP4MxADl6vYFmmBNiAgO5NPXxLKBqeg9/3Bg 0jrQ== Received: by 10.182.77.230 with SMTP id v6mr36883508obw.66.1358123938267; Sun, 13 Jan 2013 16:38:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.153.70 with HTTP; Sun, 13 Jan 2013 16:38:38 -0800 (PST) In-Reply-To: <50F32981.9080404@openwrt.org> References: <50F32981.9080404@openwrt.org> From: Yuchung Cheng Date: Sun, 13 Jan 2013 16:38:38 -0800 Message-ID: To: Felix Fietkau Content-Type: multipart/alternative; boundary=f46d0443ff7ee6c42404d334de74 X-Gm-Message-State: ALoCoQnEez/+e9jcgIjhYp8KIPzu+FRupHOCnfpd15obWxyFfd+jXPVd4ak30eAA52LSYI3Qj688BGsxkOWwGBwr6u9zr1Qc14oz7Ylhgw4B5fIMOhFFePClhaA812sc+1R/CU65lT8Oy2DCKrwnJ9HD6PjM0l82gFn3juXugr+kqi7TNHQMOYRIDRUKxNRVzgIiHsAL4PK5JNZFZ86/k4CaFJCZKOy4Fg== Cc: Jerry Chu , Eric Dumazet , cerowrt-devel Subject: Re: [Cerowrt-devel] TFO crashes cerowrt 3.7.1-1 X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2013 00:38:59 -0000 --f46d0443ff7ee6c42404d334de74 Content-Type: text/plain; charset=ISO-8859-1 Thanks for making these efforts to debug this. Ketan: can we try replace the one BUG_ON with two WARN_ON to confirm the exact faulty condition? I wish I can do that myself but I don't have a box at hand. Yuchung On Sun, Jan 13, 2013 at 1:39 PM, Felix Fietkau wrote: > On 2013-01-13 7:03 PM, Eric Dumazet wrote: > > I suspect a bug in the spin_is_locked() implementation on your arch, as > > he socket lock should be held at this point. > I don't think this is an arch implementation bug, this probably happens > on all !SMP systems. See this bit from include/linux/spinlock_up.h: > > #define arch_spin_is_locked(lock) ((void)(lock), 0) > > - Felix > > --f46d0443ff7ee6c42404d334de74 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thanks for making these efforts to debug this. Ketan: can we try repla= ce the one BUG_ON with two WARN_ON =A0to confirm the exact faulty condition= ? I wish I can do that myself but I don't have a box at hand.

Yuchung

On Sun, Jan 13, = 2013 at 1:39 PM, Felix Fietkau <nbd@openwrt.org> wrote:
On 2013-01-13 7:03 PM, Eric Dumazet wrote:
> I suspect a bug in the spin_is_locked() implementation on your arch, a= s
> he socket lock should be held at this point.
I don't think this is an arch implementation bug, this probably h= appens
on all !SMP systems. See this bit from include/linux/spinlock_up.h:

#define arch_spin_is_locked(lock) =A0 ((void)(lock), 0)

- Felix


--f46d0443ff7ee6c42404d334de74--