From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from uplift.swm.pp.se (swm.pp.se [212.247.200.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by huchra.bufferbloat.net (Postfix) with ESMTPS id BD88021FC57 for ; Mon, 29 Jun 2015 00:54:41 -0700 (PDT) Received: by uplift.swm.pp.se (Postfix, from userid 501) id CF6D7A1; Mon, 29 Jun 2015 09:54:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=swm.pp.se; s=mail; t=1435564477; bh=wS8urWAO7PNpH6yicEAhjjtZ9xsDMqKyTEzHDkir/0s=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bjCkB2JQo5/kr51cYMIgSp4swEfiK04GBikGHYnoBlWWzZuuJjj+xB2vpqY0rB3gb pCLIH9Ia+BaQv7INj67L/Z9uroqJrtIcBjtQxGQXZfOKR6VndcuJ0sOeMmCBd1NsLl IN8attEnr3AVMpDi4Q8NZcoHrosr7uQ3MxAkA0G0= Received: from localhost (localhost [127.0.0.1]) by uplift.swm.pp.se (Postfix) with ESMTP id CA0C69F; Mon, 29 Jun 2015 09:54:37 +0200 (CEST) Date: Mon, 29 Jun 2015 09:54:37 +0200 (CEST) From: Mikael Abrahamsson To: Sebastian Moeller In-Reply-To: Message-ID: References: <8B853F1C-DE5D-4F3D-88CC-CB8DA2D3E8B1@gmx.de> <04331509-F163-4184-90B4-8589073AFD62@gmx.de> <09BA156C-460D-4794-A082-33E805F3D6FD@gmx.de> <5436B48C-0803-46DA-B355-14E917A5BB37@gmx.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) Organization: People's Front Against WWW MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-137064504-1754496264-1435564477=:9487" Cc: "cerowrt-devel@lists.bufferbloat.net" Subject: Re: [Cerowrt-devel] performance numbers from WRT1200AC (Re: Latest build test - new sqm-scripts seem to work; "cake overhead 40" didn't) X-BeenThere: cerowrt-devel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development issues regarding the cerowrt test router project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 07:55:10 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---137064504-1754496264-1435564477=:9487 Content-Type: TEXT/PLAIN; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 29 Jun 2015, Sebastian Moeller wrote: > Good work-around; not a real solution as sqm_logger() will also > add "SQM:”. I think the solution most likely is to remove line 155 > completely. But weirdly this seems to work with cerowrt… May I suggest a wrapper around the logger part that handles this case, ie if the string is empty? Because when the string is empty and it gets stuck, luci just waits and waits and waits. I mean, this specific case can be fixed, but for the future it would be more robust if this error case can't happen at all. -- Mikael Abrahamsson email: swmike@swm.pp.se ---137064504-1754496264-1435564477=:9487--