From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: codel@lists.bufferbloat.net, "Dave Täht" <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH] Preliminary codel implementation
Date: Thu, 03 May 2012 20:19:12 +0200 [thread overview]
Message-ID: <1336069152.3752.46.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAA93jw74ApHzegvuXQ_SOUDR6Da7U1XDc=LS4am5d_uNw-NY7Q@mail.gmail.com>
On Thu, 2012-05-03 at 11:01 -0700, Dave Taht wrote:
> This does compile, and does not crash the kernel, and it even
> passes traffic! but...
>
> as noted I goofed on the netlink interface somehow,
> and as this is a transliteration from C++ and ns2 slides into
> C and linux network scheduling code, that I started writing at 2AM...
>
> I could also have goofed in multiple other places.
>
> I built these against linux-stable 3.3.4 and iproute current git head.
>
> So a bit of review for logical and technical correctness is highly desired.
I believe you can take time to test and polish your code before sending
it.
No hurry, this wont save the planet.
next prev parent reply other threads:[~2012-05-03 18:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 17:52 [Codel] [PATCH] iproute2: added preliminary codel support Dave Täht
2012-05-03 17:52 ` [Codel] [PATCH] Preliminary codel implementation Dave Täht
2012-05-03 18:01 ` Dave Taht
2012-05-03 18:17 ` Rick Jones
2012-05-03 18:19 ` Eric Dumazet [this message]
2012-05-03 18:17 ` Eric Dumazet
2012-05-03 22:38 ` Dave Taht
2012-05-03 20:47 ` Jim Gettys
2012-05-03 21:35 ` Dave Taht
2012-05-03 23:12 ` Jim Gettys
2012-05-03 17:59 ` [Codel] [PATCH] iproute2: added preliminary codel support Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336069152.3752.46.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=codel@lists.bufferbloat.net \
--cc=dave.taht@bufferbloat.net \
--cc=dave.taht@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox