From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-bk0-f43.google.com (mail-bk0-f43.google.com
	[209.85.214.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id CE18320061E
	for <codel@lists.bufferbloat.net>; Thu,  3 May 2012 11:19:17 -0700 (PDT)
Received: by bkty5 with SMTP id y5so3604195bkt.16
	for <codel@lists.bufferbloat.net>; Thu, 03 May 2012 11:19:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=DfHPDdssIGlWeKGBERQuH7PXjG7veh6rKfJx9v9ezW8=;
	b=G0JhxSJDSCdRfC3NIDXW6vUjKRXJ+jaczgvOlGfbxnRwMCyi88C2AowY39M3Ty948q
	pxVy/zMx9cD+jqIKkWT+1Hdeh/qh/3MrkJ5Tpf43V364qJkiKwNaSEzYTjCAiIvEL6u+
	2SQui4oh2kx2qmn+aEHocZPCO6L83L3Q7G+nWkfYxdhCf+EkkGCfNeNuUg/8mTRnor5u
	+S8aOsMqE7itkkQVTeqrlU+bnIvn/mkW8lNkcvjPuhUXBTkFtMi6o7MND6iLzgnfS5c5
	dw1UmOVcvZSNcrhYv18LDc7nM2VtiK0SEJ8O1t+LXJ1A/N2tkeDG9X2PQkTHctxNhetw
	KwsQ==
Received: by 10.204.145.70 with SMTP id c6mr1121927bkv.41.1336069155932;
	Thu, 03 May 2012 11:19:15 -0700 (PDT)
Received: from [172.28.131.195] ([74.125.122.49])
	by mx.google.com with ESMTPS id fw10sm4704024bkc.11.2012.05.03.11.19.14
	(version=SSLv3 cipher=OTHER); Thu, 03 May 2012 11:19:14 -0700 (PDT)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
In-Reply-To: <CAA93jw74ApHzegvuXQ_SOUDR6Da7U1XDc=LS4am5d_uNw-NY7Q@mail.gmail.com>
References: <1336067533-16923-1-git-send-email-dave.taht@bufferbloat.net>
	<1336067533-16923-2-git-send-email-dave.taht@bufferbloat.net>
	<CAA93jw74ApHzegvuXQ_SOUDR6Da7U1XDc=LS4am5d_uNw-NY7Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 03 May 2012 20:19:12 +0200
Message-ID: <1336069152.3752.46.camel@edumazet-glaptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: codel@lists.bufferbloat.net,
	Dave =?ISO-8859-1?Q?T=E4ht?= <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH] Preliminary codel implementation
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/private/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2012 18:19:18 -0000

On Thu, 2012-05-03 at 11:01 -0700, Dave Taht wrote:
> This does compile, and does not crash the kernel, and it even
> passes traffic! but...
> 
> as noted I goofed on the netlink interface somehow,
> and as this is a transliteration from C++ and ns2 slides into
> C and linux network scheduling code, that I started writing at 2AM...
> 
> I could also have goofed in multiple other places.
> 
> I built these against linux-stable 3.3.4 and iproute current git head.
> 
> So a bit of review for logical and technical correctness is highly desired.

I believe you can take time to test and polish your code before sending
it. 

No hurry, this wont save the planet.