From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id EFD542012AC for ; Sat, 5 May 2012 10:07:39 -0700 (PDT) Received: by wejx9 with SMTP id x9so4445218wej.16 for ; Sat, 05 May 2012 10:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=QyOA7vbYp1+9WttgEdMs7T77974Jj4j+sc7fjdI8Rzg=; b=v1uFjER0BWSfQx0tKLJEh5UfrldAEWUiqSNi2p1aGN1O98ViONT2Ukx76dd3Y2Pma2 FIMEZCPXA9mT+xjydcMVjLEPlAYLMqtmgQCxuxs9t2DioyVtd12DhuD/04bwvPDmSNfx xOgW5lm0iy2cQFtUkbfdwZ8miAHksmWLwLaO1s8pyB79xAYo4K3t6fuPYtqLSXMmP3pM 4P54OA/vYS8OPrp3KpfTi8RAB1iqo7v+DyUuYCmiyYZu7da7freBoRzqkEwILPKBqtgI bwHY6AhUVMlow0+AIyFdpWMTOxSgbhU1cYtZYqgfCvpMozP5latKuvz3/Dgrj9RCBw7s yiIg== Received: by 10.180.109.197 with SMTP id hu5mr197767wib.8.1336237657805; Sat, 05 May 2012 10:07:37 -0700 (PDT) Received: from [172.28.130.107] ([74.125.122.49]) by mx.google.com with ESMTPS id fo7sm5784231wib.9.2012.05.05.10.07.35 (version=SSLv3 cipher=OTHER); Sat, 05 May 2012 10:07:36 -0700 (PDT) From: Eric Dumazet To: Dave Taht In-Reply-To: References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net> <1336218794.3752.508.camel@edumazet-glaptop> <1336229343.3752.516.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" Date: Sat, 05 May 2012 19:07:34 +0200 Message-ID: <1336237654.3752.524.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Cc: codel@lists.bufferbloat.net, Dave =?ISO-8859-1?Q?T=E4ht?= Subject: Re: [Codel] [PATCH v5] pkt_sched: codel: Controlled Delay AQM X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2012 17:07:40 -0000 On Sat, 2012-05-05 at 09:11 -0700, Dave Taht wrote: > Nice! > > Nits: > > 0) I figure you already have an iproute2 patch that you can send? > I thought 5 hours ago I had almost, but not entirely grokked netlink. > The way you just did it was not at all how I thought it worked. :/ > but I will read. I'll send it ( I am currently with friends ...), but you dont need it to use codel with default params : qdisc add dev $DEV parent 1:1 handle 10: est 1sec 4sec codel > 1) I take it if a limit is not specified or set here, sch->limit comes > from txqueuelen? No, you set a default limit of 1000 in your patch > I do kind of like infinite queues (and angels dancing on the heads of pins) > 2) I woke up with a mod that could do ecn. I'll do an rfc patch Not sure it can play, if all packets are ECN, you need to drop at some point. > . > 3) Tom's already on the list ok > 4) I'd like to play with this a lot (and have others do so too) before > it goes upstream, > gain kathie and vans blessing, etc. Couple weeks? (see 2). In > particular I was > hoping to see actual pings under load match the target setting. > I'll get this > going on two boxes and see what happens... play with bql, htb, etc... Hey, you'll send the patch when ready. > 5) thought the * 16 could be efficiently implemented by the compiler, > and saves a mem > access. Well, just see the code on x86_32, the ktime conversion is expensive. Access to memory is free since cache line is already in cpu cache. By the way, I found the precalculated array of 64 values is not really useful, we have q->count > 64 most of the time with 2 flows. > 6) unless 2) happens we can kill q->flags Yes