From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
	[209.85.212.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 0DB5720061E
	for <codel@lists.bufferbloat.net>; Sat,  5 May 2012 13:36:13 -0700 (PDT)
Received: by wibhm17 with SMTP id hm17so2086767wib.4
	for <codel@lists.bufferbloat.net>; Sat, 05 May 2012 13:36:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=q2zI4VgB6HiAthGTq4R/8Vaj6jEhwfl2mmI3IenmIdg=;
	b=q+gLjD1g15ovMLqULc2mKgHQjbwasuFtbPEbdU/4Mm7OuyoFezjO3ceRSCRu8xDLBB
	dHlni8TpeoVQMvk/oDEuejNgJFpEZv/HfsPgHOatN2+qUzXT9xG9kyIwjl5EnpCLsEFj
	ygxk00isQ7ypMsljqh25wTIetbOKA+U2NcuyfIofeEvtOFpA3Bh4dDf98QsuCa/yUHM6
	9tVy9KDKAvKXIy3DK/+eLRZFo4Fk88MtexFIF/CMWi+GxoW2kZ2vmmWMx3td6aL8Z09V
	8j7twxsqEo98XPGbKfhH8TR6IgI/0okbBBwU8Ay0nHVInL8ugd1MfLIH1hdA2GpWIv9V
	n4oA==
Received: by 10.180.104.231 with SMTP id gh7mr23060284wib.10.1336250172069;
	Sat, 05 May 2012 13:36:12 -0700 (PDT)
Received: from [172.28.130.107] ([74.125.122.49])
	by mx.google.com with ESMTPS id fn2sm13160439wib.0.2012.05.05.13.36.09
	(version=SSLv3 cipher=OTHER); Sat, 05 May 2012 13:36:10 -0700 (PDT)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
In-Reply-To: <1336249251.3752.558.camel@edumazet-glaptop>
References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net>
	<CAA93jw4dXsn+ZCQH+LtZLqBqKXE+q3RUS97Avjy2dHHaCZ+_NA@mail.gmail.com>
	<1336218794.3752.508.camel@edumazet-glaptop>
	<1336229343.3752.516.camel@edumazet-glaptop>
	<1336249251.3752.558.camel@edumazet-glaptop>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 05 May 2012 22:36:08 +0200
Message-ID: <1336250168.3752.560.camel@edumazet-glaptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: codel@lists.bufferbloat.net,
	Dave =?ISO-8859-1?Q?T=E4ht?= <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH v5] pkt_sched: codel: Controlled Delay AQM
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/private/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 05 May 2012 20:36:14 -0000

On Sat, 2012-05-05 at 22:20 +0200, Eric Dumazet wrote:

> I believe we should allow the last packet to be sent even if
> sch->qstats.backlog >= q->minbytes
> 
> Hmm... this means we should do the 
> sch->qstats.backlog -= qdisc_pkt_len(skb);
> right after the calls to __skb_dequeue(&sch->q);
> 
> (and not in the codel_drop() or at end of codel_dequeue())
> 
> 

I am also adding a dump_stats capability, so I'll resend a v6

(So that we can check runtime param like 'q->count' and other
interesting stuff)