From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-we0-f171.google.com (mail-we0-f171.google.com
	[74.125.82.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 39E562012AC
	for <codel@lists.bufferbloat.net>; Sat,  5 May 2012 14:11:29 -0700 (PDT)
Received: by wejx9 with SMTP id x9so4564934wej.16
	for <codel@lists.bufferbloat.net>; Sat, 05 May 2012 14:11:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=kwpB86LrhPZKOepqhvXKQ4bj4oMag8ltTTjieVYtAy0=;
	b=OAQMeGkP+SsKJNwYw8qtpm7np7e7XpSn2gheIKIOp005eTlPjRUq8XBEJ6JneX3kv/
	KhV9tsz6V4J73KGaesgnO/n3sh5NML+TC6fSa0RaJi3HV9jmiOo+W122tZBUZaofRBlT
	Z0OhoxJFKY4IRxrgccY33oK9dvKWud+y8iN+7FwJbK9x9a6QL3yFTzqg9vtFXkO8xaUY
	R58xSonMfp6kocUqVW2tmCRdiHWDeyhAFvm/rUSFi1r7kBhGkPD+Bxgch934MzLo0Gs1
	ru55b+1tjeN2gv4D+C2UbaGwAfbFbNs7MY3cd0xYaSt/0kTcl5EguuFooDnuIA1/ClI5
	X6RQ==
Received: by 10.180.104.230 with SMTP id gh6mr23056517wib.22.1336252287101;
	Sat, 05 May 2012 14:11:27 -0700 (PDT)
Received: from [172.28.130.107] ([74.125.122.49])
	by mx.google.com with ESMTPS id l5sm8757141wia.11.2012.05.05.14.11.23
	(version=SSLv3 cipher=OTHER); Sat, 05 May 2012 14:11:25 -0700 (PDT)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
In-Reply-To: <1336250168.3752.560.camel@edumazet-glaptop>
References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net>
	<CAA93jw4dXsn+ZCQH+LtZLqBqKXE+q3RUS97Avjy2dHHaCZ+_NA@mail.gmail.com>
	<1336218794.3752.508.camel@edumazet-glaptop>
	<1336229343.3752.516.camel@edumazet-glaptop>
	<1336249251.3752.558.camel@edumazet-glaptop>
	<1336250168.3752.560.camel@edumazet-glaptop>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 05 May 2012 23:11:21 +0200
Message-ID: <1336252281.3752.561.camel@edumazet-glaptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: codel@lists.bufferbloat.net,
	Dave =?ISO-8859-1?Q?T=E4ht?= <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH v5] pkt_sched: codel: Controlled Delay AQM
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/private/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 05 May 2012 21:11:29 -0000

On Sat, 2012-05-05 at 22:36 +0200, Eric Dumazet wrote:
> On Sat, 2012-05-05 at 22:20 +0200, Eric Dumazet wrote:
> 
> > I believe we should allow the last packet to be sent even if
> > sch->qstats.backlog >= q->minbytes
> > 
> > Hmm... this means we should do the 
> > sch->qstats.backlog -= qdisc_pkt_len(skb);
> > right after the calls to __skb_dequeue(&sch->q);
> > 
> > (and not in the codel_drop() or at end of codel_dequeue())
> > 
> > 
> 
> I am also adding a dump_stats capability, so I'll resend a v6
> 
> (So that we can check runtime param like 'q->count' and other
> interesting stuff)
> 
> 

I believe we can remove the cache of 64 values, since q->count is way
bigger most if the time, according to my results.