From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-we0-f171.google.com (mail-we0-f171.google.com
	[74.125.82.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id DCD622012AC
	for <codel@lists.bufferbloat.net>; Sat,  5 May 2012 14:20:39 -0700 (PDT)
Received: by wejx9 with SMTP id x9so4569104wej.16
	for <codel@lists.bufferbloat.net>; Sat, 05 May 2012 14:20:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=6PskCeARy+mPDtbZ2K298kONFMdc/kBlDKSBoSLni8Y=;
	b=MsmMIC5Jfh0FmLFoAWLxwwzh2wJ0kcroPPxnNrNpcheXssWOqxIZH7b2lLJi4bZSoh
	3oTFcQ3t3bbgCmVmdyjk0U1FWjm401VKlZdYBNDcXuT1k4thIKDGznNafbfIJLRQeyYc
	TJ1Ej/xqDvJNZ0h0EkGlcR/FXIOJaLQoPf1VfMHARKPuCdV/d3DQDliUQHpAcK8e0c9t
	hIUeuoGLWeT3O8Pd9UOPMD7YVtCR+AEsFEVWc0Cx16avkCghGl+nKPdh0grI22sG0hIz
	naRfjMZ4qsfLYlmUnyfPpUhifS2SIOXxYY7CqGHWHV4H+5dGbXi+JVlfzVo3ibGMlO/D
	xHfA==
Received: by 10.180.80.104 with SMTP id q8mr23281179wix.14.1336252837927;
	Sat, 05 May 2012 14:20:37 -0700 (PDT)
Received: from [172.28.130.107] ([74.125.122.49])
	by mx.google.com with ESMTPS id fm1sm8372050wib.10.2012.05.05.14.20.34
	(version=SSLv3 cipher=OTHER); Sat, 05 May 2012 14:20:37 -0700 (PDT)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: dave taht <dave.taht@gmail.com>
In-Reply-To: <4FA597C0.7090206@gmail.com>
References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net>
	<CAA93jw4dXsn+ZCQH+LtZLqBqKXE+q3RUS97Avjy2dHHaCZ+_NA@mail.gmail.com>
	<1336218794.3752.508.camel@edumazet-glaptop>
	<1336229343.3752.516.camel@edumazet-glaptop>
	<1336249251.3752.558.camel@edumazet-glaptop>
	<1336250168.3752.560.camel@edumazet-glaptop>
	<1336252281.3752.561.camel@edumazet-glaptop>
	<4FA597C0.7090206@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 05 May 2012 23:20:32 +0200
Message-ID: <1336252832.3752.563.camel@edumazet-glaptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: codel@lists.bufferbloat.net,
	Dave =?ISO-8859-1?Q?T=E4ht?= <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH v5] pkt_sched: codel: Controlled Delay AQM
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/private/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 05 May 2012 21:20:40 -0000

On Sat, 2012-05-05 at 14:12 -0700, dave taht wrote:
> On 05/05/2012 02:11 PM, Eric Dumazet wrote:
> > On Sat, 2012-05-05 at 22:36 +0200, Eric Dumazet wrote:
> >> On Sat, 2012-05-05 at 22:20 +0200, Eric Dumazet wrote:
> >>
> >>> I believe we should allow the last packet to be sent even if
> >>> sch->qstats.backlog>= q->minbytes
> >>>
> >>> Hmm... this means we should do the
> >>> sch->qstats.backlog -= qdisc_pkt_len(skb);
> >>> right after the calls to __skb_dequeue(&sch->q);
> >>>
> >>> (and not in the codel_drop() or at end of codel_dequeue())
> >>>
> >>>
> >> I am also adding a dump_stats capability, so I'll resend a v6
> >>
> >> (So that we can check runtime param like 'q->count' and other
> >> interesting stuff)
> >>
> >>
> > I believe we can remove the cache of 64 values, since q->count is way
> > bigger most if the time, according to my results.
> >
> >
> >
> I went the other way and made it be 1000. How much bigger?
> 

We can compute the thing in less time than a cache line miss.

So I removed the cache, it makes code simpler.