From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
	[209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 45149200CCC
	for <codel@lists.bufferbloat.net>; Sat,  5 May 2012 14:58:09 -0700 (PDT)
Received: by wibhn14 with SMTP id hn14so1914487wib.10
	for <codel@lists.bufferbloat.net>; Sat, 05 May 2012 14:58:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=CZmD6A2/9OJpmVXN/ccLFSujl6lPChk0W4eETM9wcuU=;
	b=HL9kZQfl3BBgq2Bi/zhc0Ust2RFe4sdrYh19/uKp7XgJjYEBZlZsWU9WKziovxiQEb
	1FG8e6iHwYtpzZpqT/grEAvYdPVQCUrX0QuzkTtiPMutUavTm1LwkRx3BCNoC/70sNcD
	vzs8fOUfoFQRJKb5m9PfhaXKsiVrIDVbIo00WjNiVbR2cQ/WodDlLXWnbHdfiR87FB1+
	dJJKueTf1BIJZMnuh/J3A6cE9pwTd+a9iRJFboSgMOY+JMNyUaj4p8qTRSkfADk6kNcE
	vHnmDm4nrmkBZ73Yu9FTBmMd/O/KXxgYF7oJP2pafGJz/TfIvuSlOcBoZMjW9cVQUr4L
	RBeg==
Received: by 10.180.95.4 with SMTP id dg4mr9763907wib.2.1336255087246;
	Sat, 05 May 2012 14:58:07 -0700 (PDT)
Received: from [172.28.130.107] ([74.125.122.49])
	by mx.google.com with ESMTPS id n20sm13871102wiw.5.2012.05.05.14.58.05
	(version=SSLv3 cipher=OTHER); Sat, 05 May 2012 14:58:06 -0700 (PDT)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: dave taht <dave.taht@gmail.com>
In-Reply-To: <1336253330.3752.564.camel@edumazet-glaptop>
References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net>
	<CAA93jw4dXsn+ZCQH+LtZLqBqKXE+q3RUS97Avjy2dHHaCZ+_NA@mail.gmail.com>
	<1336218794.3752.508.camel@edumazet-glaptop>
	<1336229343.3752.516.camel@edumazet-glaptop>
	<1336249251.3752.558.camel@edumazet-glaptop>
	<1336250168.3752.560.camel@edumazet-glaptop>
	<1336252281.3752.561.camel@edumazet-glaptop>
	<4FA597C0.7090206@gmail.com>
	<1336252832.3752.563.camel@edumazet-glaptop>
	<1336253330.3752.564.camel@edumazet-glaptop>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 05 May 2012 23:58:03 +0200
Message-ID: <1336255083.3752.568.camel@edumazet-glaptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: codel@lists.bufferbloat.net,
	Dave =?ISO-8859-1?Q?T=E4ht?= <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH v6] pkt_sched: codel: Controlled Delay AQM
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/private/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 05 May 2012 21:58:10 -0000

On Sat, 2012-05-05 at 23:28 +0200, Eric Dumazet wrote:

OK I found the bug

> +		 * if min went above target close to when we last went below it
> +		 * assume that the drop rate that controlled the queue on the
> +		 * last cycle is a good starting point to control it now.
> +		 */
> +		if (ktime_compare(ktime_sub(now, q->drop_next), q->interval16) < 0)
> +			q->count = min(1U, q->count - 1);

	should be : 

			q->count = max(1U, q->count - 1);

> +		else
> +			q->count = 1;
> +		q->drop_next = control_law(q, now);
> +	}