From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
	[209.85.212.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 96C1C200AEE
	for <codel@lists.bufferbloat.net>; Sun,  6 May 2012 12:52:01 -0700 (PDT)
Received: by wibhn6 with SMTP id hn6so2596194wib.10
	for <codel@lists.bufferbloat.net>; Sun, 06 May 2012 12:51:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=eSLwm0PzcsIUP587fJy7n/GUZCaAAI01tRpXfEPEvME=;
	b=wTDPFbyZgoz9h1iQZMMXkytd/ebutCwr3IlYmgMg05+J20VJ0dFZAshI0bZb4dZJSx
	r8FKTXCtNU44stMJdYbaqXkR/LHcs5tZM51+qOSO78xz5vCzM+069LrIOUZtJKhi1Usa
	nN6LKN/8l6otatT/rAdcvWAeeap7R4/er5AJ3DtSyMKAhhDHCVP2mmq6q8dEjewI1QaH
	unFqffIom8OuBJvo3wbyIsSqehy2+T+uqIkd0tg1PO8Y3in9zEi8HGA3p06atbJ1Y02d
	sOaNSqCKP/PZRZHo7IoOlUtWvF8Tl8h0pdwKP1rOqa6XskwmyqS8lNh8ldjtaSvrCxGU
	rdPg==
Received: by 10.216.132.222 with SMTP id o72mr7771400wei.95.1336333919121;
	Sun, 06 May 2012 12:51:59 -0700 (PDT)
Received: from [172.30.42.18] (122.237.66.86.rev.sfr.net. [86.66.237.122])
	by mx.google.com with ESMTPS id f19sm25485649wiw.11.2012.05.06.12.51.55
	(version=SSLv3 cipher=OTHER); Sun, 06 May 2012 12:51:56 -0700 (PDT)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: dave taht <dave.taht@gmail.com>
In-Reply-To: <1336330377.3752.2107.camel@edumazet-glaptop>
References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net>
	<CAA93jw4dXsn+ZCQH+LtZLqBqKXE+q3RUS97Avjy2dHHaCZ+_NA@mail.gmail.com>
	<1336218794.3752.508.camel@edumazet-glaptop>
	<1336229343.3752.516.camel@edumazet-glaptop>
	<1336249251.3752.558.camel@edumazet-glaptop>
	<1336250168.3752.560.camel@edumazet-glaptop>
	<1336252281.3752.561.camel@edumazet-glaptop>
	<4FA597C0.7090206@gmail.com>
	<1336252832.3752.563.camel@edumazet-glaptop>
	<1336253330.3752.564.camel@edumazet-glaptop>
	<1336330377.3752.2107.camel@edumazet-glaptop>
Content-Type: text/plain; charset="UTF-8"
Date: Sun, 06 May 2012 21:51:54 +0200
Message-ID: <1336333914.3752.2230.camel@edumazet-glaptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: codel@lists.bufferbloat.net,
	Dave =?ISO-8859-1?Q?T=E4ht?= <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH v8] pkt_sched: codel: Controlled Delay AQM
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/private/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sun, 06 May 2012 19:52:02 -0000

On Sun, 2012-05-06 at 20:53 +0200, Eric Dumazet wrote:
> Some stuff added for stats and timing based on u32 fields to ease time
> compare.
> 
> An optimization for 64bit arches in calc() to avoid 16 loops to prescale
> values.

...

> +#define codel_time_after(a, b)	 ((int)(a) - (int)(b) > 0)
> +#define codel_time_after_eq(a, b) ((int)(a) - (int)(b) >= 0)
> +#define codel_time_before(a, b)	 ((int)(a) - (int)(b) < 0)
> +#define codel_time_before_eq(a, b) ((int)(a) - (int)(b) >= 0)
> +

before_eq() is wrong here (but not used in this file)