From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 03021201B46 for ; Sun, 6 May 2012 22:50:38 -0700 (PDT) Received: by wgbfa7 with SMTP id fa7so3611964wgb.28 for ; Sun, 06 May 2012 22:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=owoMlGmz4ihr/En+q/TNwUAzDHiqxCPTwcm1Fd87Ojw=; b=CG1qkgEEr1Zw81KnU4EoDRBQnpRIcbSSJ1e4KAd2IcmMInxRSEi/SfWgtzllLvJ1kM luIfa4YvKVsjyqzrTChKJkk8pIoNSH6c+kPjb1Zsv/x3Dwme8DdOPMm4PCQ8NwRfzc9e BI+2neFfJUXzY5ilqNWNlcaolQtxWrDkkHK0UHvjsvbeMqmIuQ7mh/Zkn5nxkz878cYP bWQJaMT8XyHB9PFfvRLWngoJkHSWpbC5NmnAJ6eoxkw53konTObNq1vF5sfSsFpGI5PK xpbN3ELEST8tensP/0bw4s8OAcuWJT/PnD0jWKpzzXF36sLLBiZl5aWLQVFZtp0rSQN+ 1B4A== Received: by 10.180.89.9 with SMTP id bk9mr31897603wib.11.1336369836879; Sun, 06 May 2012 22:50:36 -0700 (PDT) Received: from [192.168.1.37] (122.237.66.86.rev.sfr.net. [86.66.237.122]) by mx.google.com with ESMTPS id z3sm8409414wix.0.2012.05.06.22.50.35 (version=SSLv3 cipher=OTHER); Sun, 06 May 2012 22:50:35 -0700 (PDT) From: Eric Dumazet To: Dave =?ISO-8859-1?Q?T=E4ht?= In-Reply-To: <1336368957-17586-1-git-send-email-dave.taht@bufferbloat.net> References: <1336368957-17586-1-git-send-email-dave.taht@bufferbloat.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 07 May 2012 07:50:34 +0200 Message-ID: <1336369834.3752.2234.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Cc: codel@lists.bufferbloat.net Subject: Re: [Codel] [PATCH v9] codel: Controlled Delay AQM X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2012 05:50:39 -0000 On Sun, 2012-05-06 at 22:35 -0700, Dave Täht wrote: > This version (9) adds support for various forms of decrease in s3, > in the form of the module parameters gentle and decrease_method. > > It defaults to the algorithm as described in the original presentation. > > v1: Original implementation - Dave Taht > v2: Working code - Corrections for ktime - Dave Taht > v3: 32 bit support and port to net-next - Eric Dumazet > v4: 16 bit precision for inv sqrt and cache - Dave Taht > v5: Kernel cleanup and full precision - Eric Dumazet > v6: Dump Stats support added - Eric Dumazet > v7: Complete rewrite for u32 values - Eric Dumazet > v8: Stats and timing added, 64 bit prescale improved - Eric Dumazet > v9: debated functionality moved to isolated routine - Dave Taht > --- > +static u32 gentle = 0; > +static u32 decrease_method = 0; > +module_param(gentle, uint, 0644); > +module_param(decrease_method, uint, 0644); > +MODULE_PARM_DESC(gentle,"Gently increment count in massive drop state"); > +MODULE_PARM_DESC(decrease_method,"Various means of decreasing count"); Hey, thats absolutely forbidden. Just add new TCA_CODEL_xxx knobs to control things with tc, for each qdisc, and not globally on the machine.