CoDel AQM discussions
 help / color / mirror / Atom feed
From: "Dave Täht" <dave.taht@bufferbloat.net>
To: codel@lists.bufferbloat.net
Cc: "Dave Täht" <dave.taht@bufferbloat.net>
Subject: [Codel] [RFC PATCH] Codel: Enable packet drop with ECN-marked packets on a threshold
Date: Sun, 17 Jun 2012 15:30:17 -0700	[thread overview]
Message-ID: <1339972217-19159-1-git-send-email-dave.taht@bufferbloat.net> (raw)

Lossless IP networks are not possible. Dropping packets is the
fastest way to get back to a target delay, and if that involves
dropping ECN marked packets, so be it. When a network is in a
more steady state, ECN is fine...

My choice of "2 * target" as a threshold for dropping ECN
marked packets is entirely arbitrary.
---
 include/net/codel.h |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/net/codel.h b/include/net/codel.h
index 550debf..26944a0 100644
--- a/include/net/codel.h
+++ b/include/net/codel.h
@@ -280,7 +280,8 @@ static struct sk_buff *codel_dequeue(struct Qdisc *sch,
 						* since there is no more divide
 						*/
 				codel_Newton_step(vars);
-				if (params->ecn && INET_ECN_set_ce(skb)) {
+				if (params->ecn && INET_ECN_set_ce(skb) &&
+					vars->ldelay <= 2 * params->target) {
 					stats->ecn_mark++;
 					vars->drop_next =
 						codel_control_law(vars->drop_next,
@@ -305,7 +306,8 @@ static struct sk_buff *codel_dequeue(struct Qdisc *sch,
 			}
 		}
 	} else if (drop) {
-		if (params->ecn && INET_ECN_set_ce(skb)) {
+		if (params->ecn && INET_ECN_set_ce(skb) &&
+		        vars->ldelay <= 2 * params->target) {
 			stats->ecn_mark++;
 		} else {
 			qdisc_drop(skb, sch);
-- 
1.7.9.5


             reply	other threads:[~2012-06-17 22:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-17 22:30 Dave Täht [this message]
2012-06-18  2:17 ` Eric Dumazet
2012-06-18  2:40   ` Dave Taht
2012-06-18  2:58     ` Eric Dumazet
2012-06-18  3:01       ` Dave Taht
2012-06-18  3:10     ` Eric Dumazet
2012-06-18  3:21       ` Dave Taht
2012-06-18  3:50         ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339972217-19159-1-git-send-email-dave.taht@bufferbloat.net \
    --to=dave.taht@bufferbloat.net \
    --cc=codel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox