From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ey0-f171.google.com (mail-ey0-f171.google.com [209.85.215.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 840242012F7 for ; Mon, 9 Jul 2012 01:48:34 -0700 (PDT) Received: by eaaa12 with SMTP id a12so6637313eaa.16 for ; Mon, 09 Jul 2012 01:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=+TkyLiBBTD4TkVSSkDt9dpCXILAdo9WNUe1gZooldPY=; b=jqeVbdJvT7PYMip/i0yShWV4nKP1w+kOW7F6jz7atAULSNjbisOCjpHc1kpWN46bJ/ XgygA4+UGL7Ho17Z0icQ9w0UL54lNX+9r4hUmZp7BTK8DOjQ0eruuaTB9gxsT5QXzo1o t1kGsb/HQnsvdA+jmEXj0F6y70WwhqZEtyTp9uybrQbIw1Tq1u37a/qQ+ZsYBsBjH07J AqIbV4b2FPDRJJjL9zOURawrBfRIlKajYKJR9EyseBtxPpKUB3KsCA0FSeMzVtYrgxxc pY6qqWCbtn44csUMqSBgU5lBoEMRdb+8812+fL7u7LkwF0REYefHUERBxsc71ta1KgEF VxSw== Received: by 10.14.47.130 with SMTP id t2mr8485639eeb.21.1341823711384; Mon, 09 Jul 2012 01:48:31 -0700 (PDT) Received: from [172.30.42.18] (171.237.66.86.rev.sfr.net. [86.66.237.171]) by mx.google.com with ESMTPS id x52sm91804555eea.11.2012.07.09.01.48.27 (version=SSLv3 cipher=OTHER); Mon, 09 Jul 2012 01:48:29 -0700 (PDT) From: Eric Dumazet To: David Miller In-Reply-To: <1341821036.3265.2161.camel@edumazet-glaptop> References: <1340945457.29822.7.camel@edumazet-glaptop> <1341396687.2583.1757.camel@edumazet-glaptop> <20120709.000834.1182150057463599677.davem@davemloft.net> <1341821036.3265.2161.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 09 Jul 2012 10:48:26 +0200 Message-ID: <1341823706.3265.2257.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Cc: nanditad@google.com, netdev@vger.kernel.org, ycheng@google.com, codel@lists.bufferbloat.net, mattmathis@google.com, ncardwell@google.com Subject: Re: [Codel] [RFC PATCH] tcp: limit data skbs in qdisc layer X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 08:48:35 -0000 On Mon, 2012-07-09 at 10:04 +0200, Eric Dumazet wrote: > Only that ixgbe is not yet BQL enabled so I could not add > skb_try_orphan() in its start_xmit() : So if TX completion is a bit > delayed, we can have a throughput slowdown. Oops, ixgbe already is BQL enabled, so I can add the skb_try_orphan()