CoDel AQM discussions
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andrew McGregor <andrewmcgr@gmail.com>
Cc: codel@lists.bufferbloat.net
Subject: Re: [Codel] [RFC PATCH] codel: ecn mark at target
Date: Mon, 06 Aug 2012 22:01:09 +0200	[thread overview]
Message-ID: <1344283269.26674.62.camel@edumazet-glaptop> (raw)
In-Reply-To: <441D6067-BC04-4461-BD91-4A988A089866@gmail.com>

On Mon, 2012-08-06 at 12:09 -0700, Andrew McGregor wrote:
> On 6/08/2012, at 10:50 AM, Dave Taht <dave.taht@gmail.com> wrote:
> 
> > This discussion is getting mildly off-track. My intent in posting this patch
> > was to prove how wrong the "ecn mark at target" idea was by example,
> > and in doing so, shed light on those new to codel, on how the algorithm
> > actually works, and to encourage those that didn't grok it, to read and
> > run the code in whatever scenarios would help more people to
> > grokking in fullness.
> > 
> > I hadn't expected to twiddle a bug!
> 
> Well, so drop at target is wrong wrt deployed TCPs.  Ok, fine.
> 
> So, instead, how about this: mark instead of dropping, but only for
> the first few iterations around the while loop in dequeue (so that
> huge backlogs can be drained).  The question then is, how many is a
> few?  I suppose that can be answered empirically.
> 
> Andrew

Lets take the analogy with RED.

Once a MAX_THRESH was reached, it did a hard_mark.

So we could choose a threshold to drop instead of marking.

Possible easy choices :

1) A threshold on sojourn time. For example force_drop = 2 * target

2) A threshold on 'count'. For example force_drop if count > 1000



  reply	other threads:[~2012-08-06 20:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-04  2:44 Dave Täht
2012-08-04  6:45 ` Eric Dumazet
2012-08-04 21:53   ` Kathleen Nichols
2012-08-05  3:06     ` Andrew McGregor
2012-08-05  5:30       ` Eric Dumazet
2012-08-05 16:53         ` Andrew McGregor
2012-08-05 16:58           ` Kathleen Nichols
2012-08-05 17:14             ` Andrew McGregor
2012-08-05 17:15           ` Eric Dumazet
2012-08-05 16:54         ` Richard Scheffenegger
2012-08-05 17:25           ` Eric Dumazet
2012-08-05 17:35             ` Eric Dumazet
2012-08-05 18:14               ` Yuchung Cheng
2012-08-05 18:40                 ` Eric Dumazet
2012-08-05 19:49                   ` Eric Dumazet
2012-08-06 16:22                   ` Richard Scheffenegger
2012-08-06 16:46                     ` Eric Dumazet
2012-08-06 17:50                       ` Dave Taht
2012-08-06 19:09                         ` Andrew McGregor
2012-08-06 20:01                           ` Eric Dumazet [this message]
2012-08-10 17:48                             ` Dave Taht
2012-08-04  7:00 ` Roger Jørgensen
2012-08-04 13:38   ` Richard Scheffenegger
2012-08-04 17:21     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344283269.26674.62.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=andrewmcgr@gmail.com \
    --cc=codel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox