CoDel AQM discussions
 help / color / mirror / Atom feed
From: "Dave Täht" <dave.taht@bufferbloat.net>
To: codel@lists.bufferbloat.net
Cc: Dave Taht <dave.taht@bufferbloat.net>
Subject: [Codel] [PATCH 2/2] codel: reduce count after exiting dropping state after one maxpacket
Date: Thu, 23 Aug 2012 01:37:23 -0700	[thread overview]
Message-ID: <1345711043-4796-2-git-send-email-dave.taht@bufferbloat.net> (raw)
In-Reply-To: <1345711043-4796-1-git-send-email-dave.taht@bufferbloat.net>

From: Dave Taht <dave.taht@bufferbloat.net>

At a knife's edge, where we are rapidly entering and existing
a dropping state, seek lower to find the optimimum.
---
 include/net/codel.h |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/net/codel.h b/include/net/codel.h
index dbfccb7..5e85632 100644
--- a/include/net/codel.h
+++ b/include/net/codel.h
@@ -342,6 +342,9 @@ static struct sk_buff *codel_dequeue(struct Qdisc *sch,
 			vars->drop_next = codel_control_law(vars->drop_next,
 							    params->interval,
 							    vars->rec_inv_sqrt);
+		} else { /* we dropped out of the dropping state in 1 pkt */
+			vars->count = vars->count > 1 ? vars->count - 1 : 1;	
+			codel_Newton_step(vars);
 		}
 	}
 end:
-- 
1.7.9.5


  reply	other threads:[~2012-08-23  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  8:37 [Codel] [PATCH] codel: Refine re-entering drop state to react sooner Dave Täht
2012-08-23  8:37 ` Dave Täht [this message]
2012-08-23 14:22 ` Dave Taht
2012-08-26 18:08 ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345711043-4796-2-git-send-email-dave.taht@bufferbloat.net \
    --to=dave.taht@bufferbloat.net \
    --cc=codel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox