From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com
	[209.85.160.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client did not present a certificate)
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 8244C201B52
	for <codel@lists.bufferbloat.net>; Sat,  1 Sep 2012 05:51:26 -0700 (PDT)
Received: by pbbrq2 with SMTP id rq2so8579152pbb.16
	for <codel@lists.bufferbloat.net>; Sat, 01 Sep 2012 05:51:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=J95b9c9b/OXubo+PNuGNYYsR4x3ps54SBpFFStmx1jU=;
	b=XsGhEIHM7b78yybjj2XeTZy3iwti1jqOCX2XZABRbP1FFDe1CvbT0FTIk8RDXkJS3r
	EmQj/jaSAuWCRqiv0/DK2Pm70qAW9+VDwUtwLWqpX1jECLJv1L7rbHrRKNc3PG/5Z4M8
	VXxpR/PI6pIwZ0Bt/aHgm0nt42b7A87fCIJlq03fbW8mG3Mk3AbdCWeqYs0vXZM5+lSS
	Q3Qi0tWslyFzzwJQGmgIkKJLu9K/fho/mLj6+brfsE8msLbEreOsGQ0aTmIaBrvKBJ1S
	FMBw/kSlD9Ziep5suvWKInxc5SWT/T3f8SnIX+ii8bio7bSqBfS1DDTvrtuOaCmiH2+o
	Y/hg==
Received: by 10.68.228.100 with SMTP id sh4mr24049993pbc.45.1346503885955;
	Sat, 01 Sep 2012 05:51:25 -0700 (PDT)
Received: from [10.10.6.223] (0127ahost2.starwoodbroadband.com. [12.105.246.2])
	by mx.google.com with ESMTPS id uy3sm5634702pbc.29.2012.09.01.05.51.24
	(version=SSLv3 cipher=OTHER); Sat, 01 Sep 2012 05:51:24 -0700 (PDT)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yuchung Cheng <ycheng@google.com>
In-Reply-To: <CAK6E8=cwpq0MVK6fcrOa=wTX237xQiVP2xzh0aX-AtuSmzt-sw@mail.gmail.com>
References: <1346396137.2586.301.camel@edumazet-glaptop>
	<1346421031.2591.34.camel@edumazet-glaptop>
	<1346421466.2591.38.camel@edumazet-glaptop>
	<CAK6E8=cwpq0MVK6fcrOa=wTX237xQiVP2xzh0aX-AtuSmzt-sw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 01 Sep 2012 05:51:24 -0700
Message-ID: <1346503884.7996.65.camel@edumazet-glaptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Cc: Tomas Hruby <thruby@google.com>, Nandita Dukkipati <nanditad@google.com>,
	netdev <netdev@vger.kernel.org>, codel@lists.bufferbloat.net
Subject: Re: [Codel] [RFC v2] fq_codel : interval servo on hosts
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 01 Sep 2012 12:51:26 -0000

On Fri, 2012-08-31 at 18:37 -0700, Yuchung Cheng wrote:

> Just curious: tp->srtt is a very rough estimator, e.g., Delayed-ACks
> can easily add 40 - 200ms fuzziness. Will this affect short flows?

Good point

Delayed acks shouldnt matter, because they happen when flow had been
idle for a while.

I guess we should clamp the srtt to the default interval

if (srtt)
	q->cparams.interval = min(tcp_srtt_to_codel(srtt),
				  q->default_interval);