From: Eric Dumazet <eric.dumazet@gmail.com>
To: Kathleen Nichols <nichols@pollere.com>
Cc: Keith Winstein <keithw@mit.edu>,
"codel@lists.bufferbloat.net" <codel@lists.bufferbloat.net>
Subject: Re: [Codel] sprout
Date: Thu, 11 Jul 2013 09:22:01 -0700 [thread overview]
Message-ID: <1373559721.4600.43.camel@edumazet-glaptop> (raw)
In-Reply-To: <51DED2FF.604@pollere.com>
On Thu, 2013-07-11 at 08:45 -0700, Kathleen Nichols wrote:
> Dave, not completely sure which reservation about maxpacket is in reference.
Hi Kathleen
I believe Dave is referring to the fact that we update maxpacket every
time we dequeue a packet, and with GSO packet it makes little sense
because after a while maxpacket is set to ~65535, the limit of the GSO
packet size.
We might remove this code, and make maxpacket a constant.
diff --git a/include/net/codel.h b/include/net/codel.h
index 389cf62..470e1ff 100644
--- a/include/net/codel.h
+++ b/include/net/codel.h
@@ -170,7 +170,7 @@ static void codel_vars_init(struct codel_vars *vars)
static void codel_stats_init(struct codel_stats *stats)
{
- stats->maxpacket = 256;
+ stats->maxpacket = 1500;
}
/*
@@ -221,9 +221,6 @@ static bool codel_should_drop(const struct sk_buff *skb,
vars->ldelay = now - codel_get_enqueue_time(skb);
sch->qstats.backlog -= qdisc_pkt_len(skb);
- if (unlikely(qdisc_pkt_len(skb) > stats->maxpacket))
- stats->maxpacket = qdisc_pkt_len(skb);
-
if (codel_time_before(vars->ldelay, params->target) ||
sch->qstats.backlog <= stats->maxpacket) {
/* went below - stay below for at least interval */
next prev parent reply other threads:[~2013-07-11 16:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 19:30 Dave Taht
2013-07-10 20:19 ` Keith Winstein
2013-07-10 20:38 ` Jim Gettys
2013-07-10 20:41 ` Keith Winstein
2013-07-10 20:46 ` Jim Gettys
2013-07-10 21:42 ` Dave Taht
2013-07-10 22:10 ` Kathleen Nichols
2013-07-10 22:44 ` Dave Taht
2013-07-10 23:07 ` Eric Dumazet
2013-07-11 15:45 ` Kathleen Nichols
2013-07-11 16:22 ` Eric Dumazet [this message]
2013-07-11 16:54 ` Kathleen Nichols
2013-07-11 17:17 ` Dave Taht
2013-07-10 20:40 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373559721.4600.43.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=codel@lists.bufferbloat.net \
--cc=keithw@mit.edu \
--cc=nichols@pollere.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox