From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa0-x236.google.com (mail-oa0-x236.google.com [IPv6:2607:f8b0:4003:c02::236]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id D6E5221F185 for ; Thu, 11 Jul 2013 09:22:04 -0700 (PDT) Received: by mail-oa0-f54.google.com with SMTP id o6so11576265oag.13 for ; Thu, 11 Jul 2013 09:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:mime-version; bh=lBSINoDNy7wnLo+Bp9P1SSBj3InvymbOzwL2C1nHBcg=; b=dSPYhyMenQJUclxlEyS5fbnDajF+nCM0/WIeDSk4hK42VD0dgTwV1ETBi9Lop43Vk8 vs1HO+OjGNgdutWoZuA9l0uEugJS690OTVBmfhRGldT+Bu0Hph+k3D/9BiEIX50oxfKa 6Xn2eMP007gGXzxiWe0QiwLk0/atwxHsxVnB8A5ffTxPp9aBX5XAeW00u+ES7JdkwnZB 7SP89/xW0dlwmUD46cyxZR41HaCIbeO0eLh67jHH13DEF2bNv0t7Skp+AAiP73z5O8k5 IbWxvKwjs5BFxvazefz9MWKD/BJkrNfLFOOWhgI/Ftwbj7t7zRKmZ2OKX5tOEdIRlyan M/sg== X-Received: by 10.60.99.101 with SMTP id ep5mr32689210oeb.98.1373559723456; Thu, 11 Jul 2013 09:22:03 -0700 (PDT) Received: from ?IPv6:2620:0:1000:3304:d49d:873e:bd9b:d524? ([2620:0:1000:3304:d49d:873e:bd9b:d524]) by mx.google.com with ESMTPSA id rs4sm49834970obc.10.2013.07.11.09.22.02 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Thu, 11 Jul 2013 09:22:02 -0700 (PDT) Message-ID: <1373559721.4600.43.camel@edumazet-glaptop> From: Eric Dumazet To: Kathleen Nichols Date: Thu, 11 Jul 2013 09:22:01 -0700 In-Reply-To: <51DED2FF.604@pollere.com> References: <51DED2FF.604@pollere.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Cc: Keith Winstein , "codel@lists.bufferbloat.net" Subject: Re: [Codel] sprout X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 16:22:05 -0000 On Thu, 2013-07-11 at 08:45 -0700, Kathleen Nichols wrote: > Dave, not completely sure which reservation about maxpacket is in reference. Hi Kathleen I believe Dave is referring to the fact that we update maxpacket every time we dequeue a packet, and with GSO packet it makes little sense because after a while maxpacket is set to ~65535, the limit of the GSO packet size. We might remove this code, and make maxpacket a constant. diff --git a/include/net/codel.h b/include/net/codel.h index 389cf62..470e1ff 100644 --- a/include/net/codel.h +++ b/include/net/codel.h @@ -170,7 +170,7 @@ static void codel_vars_init(struct codel_vars *vars) static void codel_stats_init(struct codel_stats *stats) { - stats->maxpacket = 256; + stats->maxpacket = 1500; } /* @@ -221,9 +221,6 @@ static bool codel_should_drop(const struct sk_buff *skb, vars->ldelay = now - codel_get_enqueue_time(skb); sch->qstats.backlog -= qdisc_pkt_len(skb); - if (unlikely(qdisc_pkt_len(skb) > stats->maxpacket)) - stats->maxpacket = qdisc_pkt_len(skb); - if (codel_time_before(vars->ldelay, params->target) || sch->qstats.backlog <= stats->maxpacket) { /* went below - stay below for at least interval */