CoDel AQM discussions
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@gmail.com>
Cc: codel@lists.bufferbloat.net
Subject: Re: [Codel] hardware multiqueue in fq_codel?
Date: Thu, 11 Jul 2013 10:44:33 -0700	[thread overview]
Message-ID: <1373564673.4600.55.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAA93jw5SBtsz3=L9M7mhASg9oAVyvysFL9VNwc-52mOk4HWg8A@mail.gmail.com>

On Thu, 2013-07-11 at 10:09 -0700, Dave Taht wrote:
> In my default environments (wifi, mainly) the hardware queues have
> very different properties.
> 
> I'm under the impression that in at least a few ethernet devices they
> are essentially the same. That said, in the sch_mq case, an entirely
> separate qdisc is created per hardware queue, and it's always been
> puzzling to me as to how to attempt to use them within a single qdisc
> in the pull-through manner.
> 
> logically, you should be able to take the fq_codel hash index (idx %
> dev->num_tx_queues) and spread out across the hardware queues that
> way, but I have no idea where that info would go (the skb? the flow?)
> or even if it were possible as per the pull through problem...
> 
> (This does not mean that I necessarily think hardware multiqueues are
> a good idea... (certainly the results I get out of 802.11e are
> terrible - but it would be nice to have a unified solution for hw
> multiqueue devices)
> 

We do not have a fixed/unified queue selection.

It can be tweaked by many different things, depending on exact needs.

MQ is not a qdisc per se, it's only a fake one, a demux if you want, so
that each tx queue has a separate qdisc lock.

If you stick one fq_codel at the top of the hierarchy (instead of MQ),
then you loose all the pros of having multiple locks : sending packets
from fq_codel to different queues on hardware makes no sense, since the
single qdisc lock is the bottleneck.

So if you want fq_codel and MQ, to be able to drive 40G links from many
cpus, just use :

ETH=eth0
NQUEUES=16  # or more, check how many tx queues your NIC supports
tc qd del dev $ETH root 2>/dev/null
tc qd add dev $ETH root handle 1: mq
for i in `seq 1 $NQUEUES` 
do
 tc qd add dev $ETH parent 1:$i fq_codel
done

Thats only replaces the default pfifo_fast on each slave qdisc by
fq_codel.




  reply	other threads:[~2013-07-11 17:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 17:09 Dave Taht
2013-07-11 17:44 ` Eric Dumazet [this message]
2013-07-11 18:06   ` Dave Taht
2013-07-11 18:54     ` Eric Dumazet
2013-07-11 21:18       ` Dave Taht
2013-07-12  0:06         ` Eric Dumazet
2013-07-12  0:48           ` Dave Taht
2013-07-12  9:34         ` Jesper Dangaard Brouer
2013-07-12 15:13           ` Eric Dumazet
2013-07-12 16:36             ` Sebastian Moeller
2013-07-12 16:54               ` Eric Dumazet
2013-07-12 17:00                 ` Dave Taht
2013-07-15 13:40                 ` Jesper Dangaard Brouer
2013-07-15 13:57                   ` Eric Dumazet
2013-07-15 14:24                     ` Jesper Dangaard Brouer
2013-07-15 15:30                     ` Eric Dumazet
2013-07-15 17:19                     ` Dave Taht
2013-07-12 16:37             ` Dave Taht
2013-07-12 16:39               ` Dave Taht
2013-07-12 16:50               ` Eric Dumazet
2013-07-12 16:54                 ` Dave Taht
2013-07-12 17:19                   ` Eric Dumazet
2013-07-12 17:35                     ` Dave Taht
2013-07-12 17:47                       ` Eric Dumazet
2013-07-12 18:06                         ` Dave Taht
2013-07-15 12:56                     ` Jesper Dangaard Brouer
2013-07-12 17:32                   ` luca.muscariello
2013-07-11 19:41     ` Jonathan Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373564673.4600.55.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=codel@lists.bufferbloat.net \
    --cc=dave.taht@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox