From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-pa0-x22b.google.com (mail-pa0-x22b.google.com
	[IPv6:2607:f8b0:400e:c03::22b])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 8A06121F1BD
	for <codel@lists.bufferbloat.net>; Mon, 15 Jul 2013 06:57:57 -0700 (PDT)
Received: by mail-pa0-f43.google.com with SMTP id hz11so11161763pad.2
	for <codel@lists.bufferbloat.net>; Mon, 15 Jul 2013 06:57:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:subject:from:to:cc:date:in-reply-to:references
	:content-type:x-mailer:content-transfer-encoding:mime-version;
	bh=KRf1vPZJ8UKVjF+Y7wO9Lkgd50iOGqx5P93XSsGsdjo=;
	b=f/6QdmWB1tNZVFd4mr3MySAaN2+++2t6bnsapttPNOOrpDd63R5VUndDR69YOuJnTU
	dHH4yQ9twNvDls/AplE3ZTpCNWxcCmwpfOX/PpR83VXWlsjJ+cOSCrSRn7Kppqgn4LgO
	jozsdYU2QjD2YhMxr7V8MRaQ6eFyOoJwzv41O7OTkmGnZZH/1YQ1JX6W83Elb03Ar4ka
	giHlrq7iqLAceMPezPMCB9BR56OiHoRn/JHKHP/fpQVi7KHtJNI9SRDFlVrdVz8nMRDj
	3/gRjYI41GFMvtZQ6cAisuCxnGfrz5+hLIkOyUY5sOY+FI8KCD0BgzSCaF/4dJpun4cU
	VUxA==
X-Received: by 10.68.212.106 with SMTP id nj10mr53856154pbc.74.1373896675681; 
	Mon, 15 Jul 2013 06:57:55 -0700 (PDT)
Received: from [172.19.242.21] ([172.19.242.21])
	by mx.google.com with ESMTPSA id
	zv11sm64759716pab.3.2013.07.15.06.57.54 for <multiple recipients>
	(version=SSLv3 cipher=RC4-SHA bits=128/128);
	Mon, 15 Jul 2013 06:57:55 -0700 (PDT)
Message-ID: <1373896674.10804.73.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Date: Mon, 15 Jul 2013 06:57:54 -0700
In-Reply-To: <20130715154009.4c0d4531@redhat.com>
References: <CAA93jw5SBtsz3=L9M7mhASg9oAVyvysFL9VNwc-52mOk4HWg8A@mail.gmail.com>
	<1373564673.4600.55.camel@edumazet-glaptop>
	<CAA93jw6rd1G2Q4pmfAB5GPuwfqCbVPDw6njCaceszD9q5Avz_A@mail.gmail.com>
	<1373568848.4600.66.camel@edumazet-glaptop>
	<CAA93jw4+TcWOBH8mMpsk6EAO-EVzemHvx1FjPbrevEzqTJmr_A@mail.gmail.com>
	<20130712113413.4b601800@redhat.com>
	<1373642001.10804.18.camel@edumazet-glaptop>
	<FAD20AE2-21C2-43E2-8DDD-B695BA6FE6E2@gmx.de>
	<1373648057.10804.29.camel@edumazet-glaptop>
	<20130715154009.4c0d4531@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Cc: codel@lists.bufferbloat.net
Subject: Re: [Codel] hardware multiqueue in fq_codel?
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Mon, 15 Jul 2013 13:57:58 -0000

On Mon, 2013-07-15 at 15:40 +0200, Jesper Dangaard Brouer wrote:

> Then they should also be smart enough to change their default fq_codel
> qdisc, to be a prio band based qdisc... shouldn't they ;-)
> 


Some companies do this classification at the edge of their network, so
that they do not have to worry for each machine of their fleet.

Forcing them to learn how to 'fix' things once a new linux version is
installed would be quite lame. I wont be the guy responsible for this.

Listen, there is no point trying to tell me how fq_codel is better than
pfifo_fast. Is an apple better than an orange ?

Instead, we only have to create a clear path.

1) Allow the default qdisc to be specified/chosen in Kconfig, a bit
  like tcp congestion module (cubic is the default)

2) Allow the default qdisc to be selected by a /proc/sys entry, like TCP
congestion module.

3) Define the PRIO + codel/band0 + fq_codel/band1 + codel/band2 as a new
standalone qdisc

4) Eventually switch the default Kconfig from pfifo_fast to this beast.

By the way, tcp_cong.c has a race in its list handling, list_move() is
not RCU compatable.