CoDel AQM discussions
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andrew McGregor <andrewmcgr@gmail.com>
Cc: Richard Edmands <thesirdmz@gmail.com>,
	codel <codel@lists.bufferbloat.net>
Subject: Re: [Codel] Floating an Idea. ip_fq_codel
Date: Tue, 20 May 2014 08:31:41 -0700	[thread overview]
Message-ID: <1400599901.5367.129.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <CAA_e5Z4WoPW2rE66Z_N7X27A8w06JA0EsbnPkwkyJ6r-Nqs9+A@mail.gmail.com>


On Tue, 2014-05-20 at 20:16 +1000, Andrew McGregor wrote:
> That's about what constitutes a flow.  fq_codel as implemented in
> linux works per (source ip, dest ip, protocol, source port, dest port)
> 5-tuple.  Linux should probably support multiple flow hashing
> algorithms in the kernel.
> 

Right. fq_codel uses the same trick than other qdisc, like SFQ

By _default_ it uses a 5-tuple hash. Thats convenient but not a
requirement.

You can classify packets using a filter and for example hash only on the
part you need. For example destination IP, or source IP, depending if
you use fq_codel on egress or ingress sides.

tc qdisc add dev eth0 root handle 1: fq_codel flows 8192
tc filter add dev eth0 protocol ip parent 1: handle 1 \
	flow hash keys dst divisor 8192

Simple as that.

> On Tue, May 20, 2014 at 7:15 PM, Richard Edmands <thesirdmz@gmail.com>
> wrote:
>         In my environment we've got a fair chunk of torrent usage
>         happening (+ gaming) and with fq_codel giving the advantage to
>         whichever individual could open up as many connections as
>         possible the entire situation imploded very quickly.
>         
>         So to balance this out I used htb to implement the IP part of
>         this (actually not really, i made groups of ip's which
>         belonged to individuals) and stuck fq_codel on top of the
>         divided setup.
>         
>         With this system what now happens is each IP now gets equal
>         utilization of the link (actually, i'm a lazy hack. I only
>         implemented the uplink section) which prevents the advantage
>         of opening up as many connections as possible. 
>         Now when an individual decides to go nuts, they're limited to
>         what is available to them without harming everyone else,
>         without compromising maximum possible speed.
>         
>         
>         I have had this running in my environment for the past month
>         and WOW.
>         
>         
>         See pastebin'd implementation.
>         
>         
>         http://pastebin.com/hXtzFL9f
>         
>         
>         _______________________________________________
>         Codel mailing list
>         Codel@lists.bufferbloat.net
>         https://lists.bufferbloat.net/listinfo/codel
>         
> 
> 
> _______________________________________________
> Codel mailing list
> Codel@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/codel



  parent reply	other threads:[~2014-05-20 15:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  9:15 Richard Edmands
2014-05-20 10:16 ` Andrew McGregor
2014-05-20 14:34   ` Dave Taht
2014-05-20 15:31   ` Eric Dumazet [this message]
2014-05-20 15:38     ` Eric Dumazet
2014-05-21  0:15     ` Andrew McGregor
2014-06-07  1:56 ` Dan Siemon
2014-06-20  9:35   ` Richard Edmands
2014-06-20 17:04     ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400599901.5367.129.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=andrewmcgr@gmail.com \
    --cc=codel@lists.bufferbloat.net \
    --cc=thesirdmz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox