CoDel AQM discussions
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andrew McGregor <andrewmcgr@gmail.com>
Cc: Richard Edmands <thesirdmz@gmail.com>,
	codel <codel@lists.bufferbloat.net>
Subject: Re: [Codel] Floating an Idea. ip_fq_codel
Date: Tue, 20 May 2014 08:38:47 -0700	[thread overview]
Message-ID: <1400600327.5367.132.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1400599901.5367.129.camel@edumazet-glaptop2.roam.corp.google.com>

On Tue, 2014-05-20 at 08:31 -0700, Eric Dumazet wrote:
> On Tue, 2014-05-20 at 20:16 +1000, Andrew McGregor wrote:
> > That's about what constitutes a flow.  fq_codel as implemented in
> > linux works per (source ip, dest ip, protocol, source port, dest port)
> > 5-tuple.  Linux should probably support multiple flow hashing
> > algorithms in the kernel.
> > 
> 
> Right. fq_codel uses the same trick than other qdisc, like SFQ
> 
> By _default_ it uses a 5-tuple hash. Thats convenient but not a
> requirement.
> 
> You can classify packets using a filter and for example hash only on the
> part you need. For example destination IP, or source IP, depending if
> you use fq_codel on egress or ingress sides.
> 
> tc qdisc add dev eth0 root handle 1: fq_codel flows 8192
> tc filter add dev eth0 protocol ip parent 1: handle 1 \
> 	flow hash keys dst divisor 8192

Btw, while fq_codel can have 'flows xxx'  with any value for xxx,
the filter part requires 'divisor power_of_two', because it uses a AND
operation, not a MODULO.

So I doubt the filter at line 63 of http://pastebin.com/hXtzFL9f 
has any chance working. It probably is not installed.




  reply	other threads:[~2014-05-20 15:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  9:15 Richard Edmands
2014-05-20 10:16 ` Andrew McGregor
2014-05-20 14:34   ` Dave Taht
2014-05-20 15:31   ` Eric Dumazet
2014-05-20 15:38     ` Eric Dumazet [this message]
2014-05-21  0:15     ` Andrew McGregor
2014-06-07  1:56 ` Dan Siemon
2014-06-20  9:35   ` Richard Edmands
2014-06-20 17:04     ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400600327.5367.132.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=andrewmcgr@gmail.com \
    --cc=codel@lists.bufferbloat.net \
    --cc=thesirdmz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox