From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-pb0-x231.google.com (mail-pb0-x231.google.com
	[IPv6:2607:f8b0:400e:c01::231])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority G2" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id A2A9121F285
	for <codel@lists.bufferbloat.net>; Tue, 20 May 2014 08:38:56 -0700 (PDT)
Received: by mail-pb0-f49.google.com with SMTP id jt11so429686pbb.36
	for <codel@lists.bufferbloat.net>; Tue, 20 May 2014 08:38:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:subject:from:to:cc:date:in-reply-to:references
	:content-type:content-transfer-encoding:mime-version;
	bh=xt1nhoGRzJqBkb4i4xbHlZuLazRG2Cp2CBFRbvgkrKk=;
	b=jFnMblP/TdkN27NnPgveCk632DKQ2t2ze1WNkeCdP8QlSEfy9ONIn3Ty9gb6lQ+d5R
	n8FmFqlkGuwzlJpPxC3UyAd1ixPGLzZPKegg2Az6uJLslTXKRrxoEOzhe/5Bh1TwcwGm
	XB/vdrdpogQ4/Ol8ovwPma4c8S88fy//axKptIsAraF1lfo2nOsch6r84lPHKDHBCYwr
	jOnTwBJ0u4QJkN63Lkt6lfrjjAA2Zy85TYe5SftwV7gsuFAhrmwCHeTa9QEVEVRMKcqG
	dZBxFg2KnhjbSra4yktCv5trWWvJtjFKH4AiDH4naIzo1zsv/fynwiwlEEnbKRWxL0Xo
	ZtBg==
X-Received: by 10.68.110.65 with SMTP id hy1mr51383002pbb.67.1400600336051;
	Tue, 20 May 2014 08:38:56 -0700 (PDT)
Received: from [172.19.253.119] ([172.19.253.119])
	by mx.google.com with ESMTPSA id
	el14sm91611863pac.31.2014.05.20.08.38.51 for <multiple recipients>
	(version=SSLv3 cipher=RC4-SHA bits=128/128);
	Tue, 20 May 2014 08:38:54 -0700 (PDT)
Message-ID: <1400600327.5367.132.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andrew McGregor <andrewmcgr@gmail.com>
Date: Tue, 20 May 2014 08:38:47 -0700
In-Reply-To: <1400599901.5367.129.camel@edumazet-glaptop2.roam.corp.google.com>
References: <CAGNxc=xY6tL94gc_rpyNjhrNQtd65qxsXjUQL=4hTtRV+CTpCg@mail.gmail.com>
	<CAA_e5Z4WoPW2rE66Z_N7X27A8w06JA0EsbnPkwkyJ6r-Nqs9+A@mail.gmail.com>
	<1400599901.5367.129.camel@edumazet-glaptop2.roam.corp.google.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Cc: Richard Edmands <thesirdmz@gmail.com>, codel <codel@lists.bufferbloat.net>
Subject: Re: [Codel] Floating an Idea. ip_fq_codel
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 20 May 2014 15:38:56 -0000

On Tue, 2014-05-20 at 08:31 -0700, Eric Dumazet wrote:
> On Tue, 2014-05-20 at 20:16 +1000, Andrew McGregor wrote:
> > That's about what constitutes a flow.  fq_codel as implemented in
> > linux works per (source ip, dest ip, protocol, source port, dest port)
> > 5-tuple.  Linux should probably support multiple flow hashing
> > algorithms in the kernel.
> > 
> 
> Right. fq_codel uses the same trick than other qdisc, like SFQ
> 
> By _default_ it uses a 5-tuple hash. Thats convenient but not a
> requirement.
> 
> You can classify packets using a filter and for example hash only on the
> part you need. For example destination IP, or source IP, depending if
> you use fq_codel on egress or ingress sides.
> 
> tc qdisc add dev eth0 root handle 1: fq_codel flows 8192
> tc filter add dev eth0 protocol ip parent 1: handle 1 \
> 	flow hash keys dst divisor 8192

Btw, while fq_codel can have 'flows xxx'  with any value for xxx,
the filter part requires 'divisor power_of_two', because it uses a AND
operation, not a MODULO.

So I doubt the filter at line 63 of http://pastebin.com/hXtzFL9f 
has any chance working. It probably is not installed.