From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x229.google.com (mail-lf0-x229.google.com [IPv6:2a00:1450:4010:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 962803B2AE for ; Thu, 31 Mar 2016 06:26:19 -0400 (EDT) Received: by mail-lf0-x229.google.com with SMTP id e133so56197926lfe.3 for ; Thu, 31 Mar 2016 03:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YiuHoXoUFolErJh2qj72LQ0Tm3qQ/4wV4ZqmKvqNezA=; b=dULOzl/rcheHSCDk523QYzb6Nbtbdgx+0p009qQOWWja6QI0UsQQCMD9gza6nFL4Kt gNBKJdV+SgH3fs1Gnlp7inTd62khETGiaOn9oWzWokkiqe0+T3aFz8KOX8Vbe1CAR205 d6t8FhEir75PBGXQfvFKo4foy9HmhxabhlSF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YiuHoXoUFolErJh2qj72LQ0Tm3qQ/4wV4ZqmKvqNezA=; b=Lh4li87ZkioHb0G6Aj3qcClAfnPmEsTyfvJdXdNlFEMUDhTOx7s5jTx4oVEJRnR6tJ rMof/gZl8oBTmOhe6wUhdPsDoG8xk8e6LUTo9qVYgD9jvjQEALLCQX9by3pq/kuBtymM KbYwSmeQ0M3N06HR91IVjdmmUl9pQKLAWrP2oJ8p8nSqifp4NONAB4EJTC6E0ca/e6/k v9GmrJoHGSyHZW15MeR9Jba9Tk4JkIA6h5jdYybV/7QoCQBi1M/6OX8boVJA+47iNhFy 8UM4oepysbkC9yC10bZUqEX+Td+2P06G95BE/H3AI27m6RoQpvDq3mlQnqfmYlXXyvPW ++Jw== X-Gm-Message-State: AD7BkJK9Ouw7YhXVA/W3H2EU+qDGmsAQ9TW+4ZiggzcQkTF7dlpHT6aFkVK/xe1fOBafOvFH7R663hXRs7E7kEUVo8IhIG1d5iOxU5xxT9RazbZVUkP778geh2dbX5469Pdj7LH4uQ== X-Received: by 10.25.150.207 with SMTP id y198mr6339689lfd.68.1459419978194; Thu, 31 Mar 2016 03:26:18 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.10]) by smtp.gmail.com with ESMTPSA id i2sm1186578lfd.43.2016.03.31.03.26.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 31 Mar 2016 03:26:17 -0700 (PDT) From: Michal Kazior To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, dave.taht@gmail.com, make-wifi-fast@lists.bufferbloat.net, codel@lists.bufferbloat.net, Michal Kazior Date: Thu, 31 Mar 2016 12:28:22 +0200 Message-Id: <1459420104-31554-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1458898052-20601-1-git-send-email-michal.kazior@tieto.com> References: <1458898052-20601-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Subject: [Codel] [PATCHv2 0/2] mac80211: implement fq_codel X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 10:26:19 -0000 Hi, I've cleaned up and removed the txop-queue-limiting and scheduling from the patch (compared to my last RFC). It's still to early for the scheduling thing to go prime time. The fair queuing on the other hand does seem to work. In good RF conditions it seems to improve things (e.g. multiple TCP streams converge into a steady average). In bad RF conditions things look same grim as before (but not worse). I've done a few more experiments with naive DQL in ath10k and some flent tests prove the fair queuing in mac80211 works better than fq_codel qdisc as far as wake_tx_queue drivers are concerned. I'll be posting a separate thread after this. This is based on mac80211-next/master (0a87cadbb54e1595a5f64542adb4c63be914d290). v2: * fix invalid ptr deref * fix compilation for backports Michal Kazior (2): mac80211: implement fair queuing per txq mac80211: expose some txq/fq internals and knobs via debugfs include/net/mac80211.h | 21 ++- net/mac80211/agg-tx.c | 8 +- net/mac80211/codel.h | 264 +++++++++++++++++++++++++++++ net/mac80211/codel_i.h | 89 ++++++++++ net/mac80211/debugfs.c | 86 ++++++++++ net/mac80211/debugfs_netdev.c | 29 +++- net/mac80211/debugfs_sta.c | 46 +++++ net/mac80211/ieee80211_i.h | 45 ++++- net/mac80211/iface.c | 24 ++- net/mac80211/main.c | 9 +- net/mac80211/rx.c | 2 +- net/mac80211/sta_info.c | 10 +- net/mac80211/sta_info.h | 27 +++ net/mac80211/tx.c | 383 +++++++++++++++++++++++++++++++++++++----- net/mac80211/util.c | 20 ++- 15 files changed, 983 insertions(+), 80 deletions(-) create mode 100644 net/mac80211/codel.h create mode 100644 net/mac80211/codel_i.h -- 2.1.4