From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [5.9.151.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3BAC73CC3C; Wed, 6 Apr 2016 03:19:55 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1anhkm-0000z0-2h; Wed, 06 Apr 2016 09:19:52 +0200 Message-ID: <1459927188.17504.4.camel@sipsolutions.net> From: Johannes Berg To: Michal Kazior Cc: linux-wireless , Dave Taht , make-wifi-fast@lists.bufferbloat.net, codel@lists.bufferbloat.net Date: Wed, 06 Apr 2016 09:19:48 +0200 In-Reply-To: (sfid-20160406_073548_268435_E6515D94) References: <1458898052-20601-1-git-send-email-michal.kazior@tieto.com> <1459420104-31554-1-git-send-email-michal.kazior@tieto.com> <1459420104-31554-2-git-send-email-michal.kazior@tieto.com> <1459864656.18188.60.camel@sipsolutions.net> (sfid-20160406_073548_268435_E6515D94) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 06 Apr 2016 13:11:42 -0400 Subject: Re: [Codel] [PATCHv2 1/2] mac80211: implement fair queuing per txq X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 07:19:55 -0000 On Wed, 2016-04-06 at 07:35 +0200, Michal Kazior wrote: > I just wanted to follow the suggested/implied usage of codel code and > keep modifications to a minimum. I could very well just assimilate it > if you wish. I don't really feel all that strongly about it, but I also don't see the point. It makes it harder to look for the code though, and that seems fairly pointless. Btw, just realized that there's also __u32 in there which you should probably remove and use just u32. Also don't #include > This follows net/sched/sch_fq_codel.h. I can put up a comment to > explain what it's supposed to do? > Ok, fair enough. johannes