From: Jonathan Morton <chromatix99@gmail.com>
To: Nandita Dukkipati <nanditad@google.com>
Cc: netdev <netdev@vger.kernel.org>,
"codel@lists.bufferbloat.net" <codel@lists.bufferbloat.net>,
Tomas Hruby <thruby@google.com>
Subject: Re: [Codel] [RFC v2] fq_codel : interval servo on hosts
Date: Tue, 4 Sep 2012 18:25:18 +0300 [thread overview]
Message-ID: <1C18E243-42BC-46F0-A336-EAD9BC881C45@gmail.com> (raw)
In-Reply-To: <CAB_+Fg5xPRqEZNdH0mYogmm4LitMvycSLB-X1_7ryn4RY9FvSA@mail.gmail.com>
I think that in most cases, a long RTT flow and a short RTT flow on the same interface means that the long RTT flow isn't bottlenecked here, and therefore won't ever build up a significant queue - and that means you would want to track over the shorter interval. Is that a reasonable assumption?
The key to knowledge is not to rely on others to teach you it.
On 4 Sep 2012, at 18:10, Nandita Dukkipati <nanditad@google.com> wrote:
> The idea of using srtt as interval makes sense to me if alongside we
> also hash flows with similar RTTs into same bucket. But with just the
> change in interval, I am not sure how codel is expected to behave.
>
> My understanding is: the interval (usually set to worst case expected
> RTT) is used to measure the standing queue or the "bad" queue. Suppose
> 1ms and 100ms RTT flows get hashed to same bucket, then the interval
> with this patch will flip flop between 1ms and 100ms. How is this
> expected to measure a standing queue? In fact I think the 1ms flow may
> land up measuring the burstiness or the "good" queue created by the
> long RTT flows, and this isn't desirable.
>
>
> On Sat, Sep 1, 2012 at 5:51 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Fri, 2012-08-31 at 18:37 -0700, Yuchung Cheng wrote:
>>
>>> Just curious: tp->srtt is a very rough estimator, e.g., Delayed-ACks
>>> can easily add 40 - 200ms fuzziness. Will this affect short flows?
>>
>> Good point
>>
>> Delayed acks shouldnt matter, because they happen when flow had been
>> idle for a while.
>>
>> I guess we should clamp the srtt to the default interval
>>
>> if (srtt)
>> q->cparams.interval = min(tcp_srtt_to_codel(srtt),
>> q->default_interval);
>>
>>
>>
> _______________________________________________
> Codel mailing list
> Codel@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/codel
next prev parent reply other threads:[~2012-09-04 15:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 6:55 [Codel] fq_codel : interval servo Eric Dumazet
2012-08-31 13:41 ` Jim Gettys
2012-08-31 13:50 ` [Codel] [RFC] fq_codel : interval servo on hosts Eric Dumazet
2012-08-31 13:57 ` [Codel] [RFC v2] " Eric Dumazet
2012-09-01 1:37 ` Yuchung Cheng
2012-09-01 12:51 ` Eric Dumazet
2012-09-04 15:10 ` Nandita Dukkipati
2012-09-04 15:25 ` Jonathan Morton [this message]
2012-09-04 15:39 ` Eric Dumazet
2012-09-04 15:34 ` Eric Dumazet
2012-09-04 16:40 ` Dave Taht
2012-09-04 16:54 ` Eric Dumazet
2012-09-04 16:57 ` Eric Dumazet
2012-08-31 15:53 ` [Codel] fq_codel : interval servo Rick Jones
2012-08-31 16:23 ` Eric Dumazet
2012-08-31 16:59 ` Dave Taht
2012-09-01 12:53 ` Eric Dumazet
2012-09-02 18:08 ` Dave Taht
2012-09-02 18:17 ` Dave Taht
2012-09-02 23:28 ` Eric Dumazet
2012-09-02 23:23 ` Eric Dumazet
2012-09-03 0:18 ` Dave Taht
2012-08-31 16:40 ` Jim Gettys
2012-08-31 16:49 ` Jonathan Morton
2012-08-31 17:15 ` Jim Gettys
2012-08-31 17:31 ` Rick Jones
2012-08-31 17:44 ` Jim Gettys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1C18E243-42BC-46F0-A336-EAD9BC881C45@gmail.com \
--to=chromatix99@gmail.com \
--cc=codel@lists.bufferbloat.net \
--cc=nanditad@google.com \
--cc=netdev@vger.kernel.org \
--cc=thruby@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox