From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dave.taht@bufferbloat.net, netdev@vger.kernel.org,
codel@lists.bufferbloat.net, bloat@lists.bufferbloat.net
Subject: Re: [Codel] [PATCH net-next] fq_codel: should use qdisc backlog as threshold
Date: Wed, 16 May 2012 15:30:37 -0400 (EDT) [thread overview]
Message-ID: <20120516.153037.524884393884635968.davem@davemloft.net> (raw)
In-Reply-To: <1337179149.8512.1208.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 May 2012 16:39:09 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> codel_should_drop() logic allows a packet being not dropped if queue
> size is under max packet size.
>
> In fq_codel, we have two possible backlogs : The qdisc global one, and
> the flow local one.
>
> The meaningful one for codel_should_drop() should be the global backlog,
> not the per flow one, so that thin flows can have a non zero drop/mark
> probability.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-05-16 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 14:39 Eric Dumazet
2012-05-16 19:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516.153037.524884393884635968.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bloat@lists.bufferbloat.net \
--cc=codel@lists.bufferbloat.net \
--cc=dave.taht@bufferbloat.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox