From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davem@davemloft.net>
Received: from shards.monkeyblade.net (shards.monkeyblade.net [198.137.202.13])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 05FEF21F0CA;
	Wed, 16 May 2012 12:31:44 -0700 (PDT)
Received: from localhost (nat-pool-rdu.redhat.com [66.187.233.202])
	(authenticated bits=0)
	by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id q4GJUc9M022044
	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO);
	Wed, 16 May 2012 12:30:39 -0700
Date: Wed, 16 May 2012 15:30:37 -0400 (EDT)
Message-Id: <20120516.153037.524884393884635968.davem@davemloft.net>
To: eric.dumazet@gmail.com
From: David Miller <davem@davemloft.net>
In-Reply-To: <1337179149.8512.1208.camel@edumazet-glaptop>
References: <1337179149.8512.1208.camel@edumazet-glaptop>
X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(shards.monkeyblade.net [198.137.202.13]);
	Wed, 16 May 2012 12:30:42 -0700 (PDT)
Cc: dave.taht@bufferbloat.net, netdev@vger.kernel.org,
	codel@lists.bufferbloat.net, bloat@lists.bufferbloat.net
Subject: Re: [Codel] [PATCH net-next] fq_codel: should use qdisc backlog as
 threshold
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Wed, 16 May 2012 19:31:44 -0000

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 May 2012 16:39:09 +0200

> From: Eric Dumazet <edumazet@google.com>
> 
> codel_should_drop() logic allows a packet being not dropped if queue
> size is under max packet size.
> 
> In fq_codel, we have two possible backlogs : The qdisc global one, and
> the flow local one.
> 
> The meaningful one for codel_should_drop() should be the global backlog,
> not the per flow one, so that thin flows can have a non zero drop/mark
> probability.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied.