CoDel AQM discussions
 help / color / mirror / Atom feed
From: Jeff Weeks <jweeks@sandvine.com>
To: "codel@lists.bufferbloat.net" <codel@lists.bufferbloat.net>
Subject: [Codel] drop state short-circuit...
Date: Tue, 11 Aug 2015 17:14:46 +0000	[thread overview]
Message-ID: <274D3A0FA900FD47AA6B56991AAA32FDC53BB45E@wtl-exchp-1.sandvine.com> (raw)

Hello,

I originally posted this in the aqm list; re-posted to this, more appropriate, list:

There exists a short-circuit into a "deeper" drop state if we were previously and recently in a drop state.  I understand the need for this, but I'm curious where the '16' came from?  How was this decided upon?

For example, here's the ns3 implementation:

          /*
           * if min went above target close to when we last went below it
           * assume that the drop rate that controlled the queue on the
           * last cycle is a good starting point to control it now.
           */
          int delta = m_count - m_lastCount;
          if (delta > 1 && CoDelTimeBefore (now - m_dropNext, 16 * Time2CoDel (m_interval)))
          {
            m_count = delta;
            NewtonStep ();
          }

If I read this correctly, it says;

If we have previously dropped for more than one interval, and have re-entered the drop state in less then 16 intervals from the previous drop state, then short circuit count to the delta... but why 16 intervals?

--Jeff

             reply	other threads:[~2015-08-11 17:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 17:14 Jeff Weeks [this message]
2015-08-11 17:35 ` Jonathan Morton
2015-08-11 18:50   ` Jeff Weeks
2015-08-11 19:13     ` Jonathan Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=274D3A0FA900FD47AA6B56991AAA32FDC53BB45E@wtl-exchp-1.sandvine.com \
    --to=jweeks@sandvine.com \
    --cc=codel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox