From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 9DD6E3CB37 for ; Sat, 14 Oct 2023 14:17:33 -0400 (EDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c16757987fso38993361fa.3 for ; Sat, 14 Oct 2023 11:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697307450; x=1697912250; darn=lists.bufferbloat.net; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Jpo5oHaquARGVwaKBVq3hchxpN86revIAtKTE0xHyMw=; b=Q31IUyYhi9yugiczTtR8TmI257WLY/kwOfqKLg/Fv3ihE8QF0EViUPQ5IpYSp1EiDw NIgp7Dquh/FxfAHc7loT9ODtwOJ/mcmnCWqaDxAh7KJAyY3Pe/kqi+y/VNsXJfRhketa /6lE2MEli3FzOoL1qDUMg4g7grZkVdgWlzJ7oeFDIbxFEc1477zNZtfOBGQBGAhXPuVl Wbye8qOx84LZ3mM1PIUeyJD9X+kgCDbAAHKzq48T5Y19cE9YEWzIUDersypsCUvGwn8T obIuCqueGWri9pcw2WtU22/8WhQ3bofWStYSYFAXI8cURC9LcWHtUEiCBsYFw9S1b9qq Xnmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697307450; x=1697912250; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jpo5oHaquARGVwaKBVq3hchxpN86revIAtKTE0xHyMw=; b=UmDu5zGoBX2ZAipCh+N6FLfRkndl+N9LWGOw1pLYNj56xJm/+wjVAza6w/elAXNxIX vhbptZKgJQX7s36awav8ucn2q7apGFWQ++FDNc4rpjP/rXCm8sh/xNbpFZXOu9TcB2p2 GeGGCORY2TzVAcn/7IEkscK5OYTphXGkv+pmosR6fy9IsPmIKFv3Q7Em7NP6AbabRKnY Uc5ZLtiMB6sm/1LXHmy0XkH3rr/TEVbMtu7WeWApoak+RV3DDm28I/Ixfw9f0FAx40VN OkDwI8l2fAaU6x7i3MRqepOL9sh88wWNLyoxwUgDZCL9JqglKJv231v5US1sBAiUEAWO GjQA== X-Gm-Message-State: AOJu0YzRIIBoHEguJqLa+ohs29px/l0iYYexZNUHU3UGHqrqVsHYw+o9 THsDhy3Y0Jof14tSpfM/j1k= X-Google-Smtp-Source: AGHT+IEFk05vTFG8gHKGzsjNCehLWmugDaQP+Jr31KoWuBXgE/XisMt4pMs0dpEdP8f3WuQUo1qSjQ== X-Received: by 2002:a2e:b8d4:0:b0:2c5:72e:6ff3 with SMTP id s20-20020a2eb8d4000000b002c5072e6ff3mr4016569ljp.37.1697307450137; Sat, 14 Oct 2023 11:17:30 -0700 (PDT) Received: from smtpclient.apple (178-55-50-108.bb.dnainternet.fi. [178.55.50.108]) by smtp.gmail.com with ESMTPSA id a5-20020a05651c010500b002c032e54948sm462439ljb.117.2023.10.14.11.17.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2023 11:17:29 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) From: Jonathan Morton In-Reply-To: Date: Sat, 14 Oct 2023 21:17:28 +0300 Cc: codel@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: <3E02B7F5-D0C6-4C33-AFA9-30A2E54B155F@gmail.com> References: To: Dave Taht X-Mailer: Apple Mail (2.3654.100.0.2.22) Subject: Re: [Codel] fq_"codel" in apple's gear X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Oct 2023 18:17:33 -0000 > On 14 Oct, 2023, at 8:23 pm, Dave Taht wrote: >=20 > I would really like someone with a fresh set of eyeballs to review the > "codel" portion of apple's latest code drop here: >=20 > = https://www.linkedin.com/feed/update/urn:li:activity:7118969694987935744/ So far as I can tell, it still implements DRR++ (with a comment = referencing RFC-8290), but not Codel (there's also no comment = referencing RFC-8289). There's at least one function for handling ECN = which is simply not called, at least not in that source file. In fact, I looked in the header to see where an ECN mark counter was = defined. It is referenced in essentially three places: the definition, = an extraction for reporting to userspace, and an increment - in a = function implementing L4S marking, not Codel. A similar counter for "early dropped" packets is incremented only when = packets have to be dropped in an emergency because the queue is *full*. = That's the other counter I would expect to be touched by an AQM = implementation. So, no tangible improvement that I can find easily. - Jonathan Morton=