From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dave.taht@gmail.com>
Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com
	[209.85.160.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id 9BEA62012AC
	for <codel@lists.bufferbloat.net>; Sat,  5 May 2012 14:12:36 -0700 (PDT)
Received: by pbcwz7 with SMTP id wz7so8873957pbc.16
	for <codel@lists.bufferbloat.net>; Sat, 05 May 2012 14:12:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=ddnVSS/+neXOi8cEFvkqbAIikqatwsJugPYsQbrHZnI=;
	b=qIg/FcM3LM4Gn0iQCuEw80L3yLf2k+2BfoctaGBbaDVWKEvRbtNiBaNMrA6gvW1ax4
	tCj4Ycp8ckXaHoDAqSt5xmzz0FD0HtxyYXM7YXwuhVoSaE+CkWUX1Vot1UivDkIa3IMM
	Nw2raSrYfJ47uCEwYG42VcDobCgxx9eTXOM8nHEAxawyNPKvVVOS6+Fh/HhqJBqwRJHF
	CFYK9ixB9hqzHq26aPQIAOiwMMVTs7qo05BUm7YdTyRPSBpoEtZHTtvmJ1DPSf1VNeXi
	kVXZb+ZLrqeGdnFqo3Wt/HF1uGmAPhFl8Tr/a8aIp1TXtIQcWSo8S5eLSs1+WsyTKTGI
	Z6TA==
Received: by 10.68.191.193 with SMTP id ha1mr5688545pbc.163.1336252355850;
	Sat, 05 May 2012 14:12:35 -0700 (PDT)
Received: from ?IPv6:2001:4f8:3:203::c001? ([2001:4f8:3:203::c001])
	by mx.google.com with ESMTPS id b10sm12824406pbr.46.2012.05.05.14.12.34
	(version=SSLv3 cipher=OTHER); Sat, 05 May 2012 14:12:34 -0700 (PDT)
Message-ID: <4FA597C0.7090206@gmail.com>
Date: Sat, 05 May 2012 14:12:32 -0700
From: dave taht <dave.taht@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120410 Thunderbird/11.0.1
MIME-Version: 1.0
To: Eric Dumazet <eric.dumazet@gmail.com>
References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net>
	<CAA93jw4dXsn+ZCQH+LtZLqBqKXE+q3RUS97Avjy2dHHaCZ+_NA@mail.gmail.com>
	<1336218794.3752.508.camel@edumazet-glaptop>
	<1336229343.3752.516.camel@edumazet-glaptop>
	<1336249251.3752.558.camel@edumazet-glaptop>
	<1336250168.3752.560.camel@edumazet-glaptop>
	<1336252281.3752.561.camel@edumazet-glaptop>
In-Reply-To: <1336252281.3752.561.camel@edumazet-glaptop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: codel@lists.bufferbloat.net,
	=?UTF-8?B?RGF2ZSBUw6RodA==?= <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [PATCH v5] pkt_sched: codel: Controlled Delay AQM
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/private/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 05 May 2012 21:12:36 -0000

On 05/05/2012 02:11 PM, Eric Dumazet wrote:
> On Sat, 2012-05-05 at 22:36 +0200, Eric Dumazet wrote:
>> On Sat, 2012-05-05 at 22:20 +0200, Eric Dumazet wrote:
>>
>>> I believe we should allow the last packet to be sent even if
>>> sch->qstats.backlog>= q->minbytes
>>>
>>> Hmm... this means we should do the
>>> sch->qstats.backlog -= qdisc_pkt_len(skb);
>>> right after the calls to __skb_dequeue(&sch->q);
>>>
>>> (and not in the codel_drop() or at end of codel_dequeue())
>>>
>>>
>> I am also adding a dump_stats capability, so I'll resend a v6
>>
>> (So that we can check runtime param like 'q->count' and other
>> interesting stuff)
>>
>>
> I believe we can remove the cache of 64 values, since q->count is way
> bigger most if the time, according to my results.
>
>
>
I went the other way and made it be 1000. How much bigger?