From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com [209.85.160.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 2A919200CCC for ; Sat, 5 May 2012 15:03:40 -0700 (PDT) Received: by pbcwz7 with SMTP id wz7so8914931pbc.16 for ; Sat, 05 May 2012 15:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=TuIxHKcwJrf7PJlBLe9SNsl0SRMaGVrMWlxQyXFsat8=; b=xPWbKW9p7XSxWLmhiFvltzAA5vxV/JVOVCkh4wNsByjJvDuNGKToyq4pmsM1jmgxA/ +I51j/YXixzY4t8uiWjkXloe8LH64KsrM0r65b9da47GbwORoaBRp/sU2cnuutxfFxZE j4CVVVS2Rr4layo2p/tQDLXZHSzfQ5ffenOKbK1L44bB5aJU7mMTr+VdHupZd+ZwuuiH hu8iYE/ouGJIL94FoRdG8PK8m2nerozisWEgmToi4PzUIlvZZw7OCqheCoePMjdkslSm 9PLCSV4T91SNDVAjFAg+YzcJWpP96HuPPlRvMJ6Ir6uzRDY011owqT3nyPIBTA8d7O8w taZg== Received: by 10.68.223.234 with SMTP id qx10mr31222400pbc.154.1336255419609; Sat, 05 May 2012 15:03:39 -0700 (PDT) Received: from ?IPv6:2001:4f8:3:203::c001? ([2001:4f8:3:203::c001]) by mx.google.com with ESMTPS id og6sm12929124pbb.42.2012.05.05.15.03.37 (version=SSLv3 cipher=OTHER); Sat, 05 May 2012 15:03:38 -0700 (PDT) Message-ID: <4FA5A3B8.7020808@gmail.com> Date: Sat, 05 May 2012 15:03:36 -0700 From: dave taht User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Eric Dumazet References: <1336217671-20384-1-git-send-email-dave.taht@bufferbloat.net> <1336218794.3752.508.camel@edumazet-glaptop> <1336229343.3752.516.camel@edumazet-glaptop> <1336249251.3752.558.camel@edumazet-glaptop> <1336250168.3752.560.camel@edumazet-glaptop> <1336252281.3752.561.camel@edumazet-glaptop> <4FA597C0.7090206@gmail.com> <1336252832.3752.563.camel@edumazet-glaptop> In-Reply-To: <1336252832.3752.563.camel@edumazet-glaptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: codel@lists.bufferbloat.net, =?UTF-8?B?RGF2ZSBUw6RodA==?= Subject: Re: [Codel] [PATCH v5] pkt_sched: codel: Controlled Delay AQM X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2012 22:03:40 -0000 On 05/05/2012 02:20 PM, Eric Dumazet wrote: > On Sat, 2012-05-05 at 14:12 -0700, dave taht wrote: >> On 05/05/2012 02:11 PM, Eric Dumazet wrote: >>> On Sat, 2012-05-05 at 22:36 +0200, Eric Dumazet wrote: >>>> On Sat, 2012-05-05 at 22:20 +0200, Eric Dumazet wrote: >>>> >>>>> I believe we should allow the last packet to be sent even if >>>>> sch->qstats.backlog>= q->minbytes >>>>> >>>>> Hmm... this means we should do the >>>>> sch->qstats.backlog -= qdisc_pkt_len(skb); >>>>> right after the calls to __skb_dequeue(&sch->q); >>>>> >>>>> (and not in the codel_drop() or at end of codel_dequeue()) >>>>> >>>>> >>>> I am also adding a dump_stats capability, so I'll resend a v6 >>>> >>>> (So that we can check runtime param like 'q->count' and other >>>> interesting stuff) >>>> >>>> >>> I believe we can remove the cache of 64 values, since q->count is way >>> bigger most if the time, according to my results. >>> >>> >>> >> I went the other way and made it be 1000. How much bigger? >> > We can compute the thing in less time than a cache line miss. Maybe on your arch, but highly doubtful on a 680Mhz mips that isn't even superscalar. I'd prefer to leave it in and be able to compile it out, and actually measure the difference. > > So I removed the cache, it makes code simpler. Well, it was fun while it lasted. > >