From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gettysjim@gmail.com>
Received: from mail-yw0-f43.google.com (mail-yw0-f43.google.com
	[209.85.213.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(Client CN "smtp.gmail.com",
	Issuer "Google Internet Authority" (verified OK))
	by huchra.bufferbloat.net (Postfix) with ESMTPS id DE7EB200B29
	for <codel@lists.bufferbloat.net>; Tue,  8 May 2012 07:47:10 -0700 (PDT)
Received: by yhkk6 with SMTP id k6so8595527yhk.16
	for <codel@lists.bufferbloat.net>; Tue, 08 May 2012 07:47:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:message-id:date:from:organization:user-agent:mime-version:to
	:cc:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=6TaXaDOP0YD00UJG0klqi+ZA28Mfp0AoGfN9LHVc02c=;
	b=KWH4H6lPmK1JcjQVMUOQsKP8SlTcVeeFMWK66Bsa761yJZ8+5+1eD8EpGjTzoWEmZv
	FdUy311s1qIcJEWKcl7bpvbXZ2Nbu7BbXFgW84k4pyBgdnbDul3L9ieraiW8thCqTtLx
	vNMRKWQmzauqKxUl8Xh7O6dX0MqxPcsrtouucZZ12i9q92xyTZneNb0hLB5/yTHWovNL
	CEavSDjAg1/y7uPBo9b+qw4eQNtsdOFc3phXzyTMqDu1b9jyIJPfL3n7DDdaefV43WQs
	Ay9LrmePBGeDQEV84FVLGs+pkqMLkcEMF2OPQ+ZpA7UZQx4MdnAmmHoMdu7rlm4hyXP0
	u8jg==
Received: by 10.236.37.202 with SMTP id y50mr24435941yha.63.1336488429845;
	Tue, 08 May 2012 07:47:09 -0700 (PDT)
Received: from [192.168.1.81] (c-50-138-162-108.hsd1.ma.comcast.net.
	[50.138.162.108])
	by mx.google.com with ESMTPS id g4sm45250624yhf.12.2012.05.08.07.47.08
	(version=SSLv3 cipher=OTHER); Tue, 08 May 2012 07:47:09 -0700 (PDT)
Sender: Jim Gettys <gettysjim@gmail.com>
Message-ID: <4FA931EB.8050001@freedesktop.org>
Date: Tue, 08 May 2012 10:47:07 -0400
From: Jim Gettys <jg@freedesktop.org>
Organization: Bell Labs
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Eric Dumazet <eric.dumazet@gmail.com>, 
	"codel@lists.bufferbloat.net" <codel@lists.bufferbloat.net>
References: <FA01AD85-0547-4824-8D86-92E78DB29913@gmail.com>
	<4FA7FBB4.3070900@freedesktop.org> <4FA8201D.9030407@pollere.com>
	<CAA93jw4mYQECJV6O1ONoe0y0+Efeu-a+QeZUiPmWVc===ncvEA@mail.gmail.com>
	<4FA88DD1.6020607@pollere.com>
	<1336487895.3752.2413.camel@edumazet-glaptop>
In-Reply-To: <1336487895.3752.2413.camel@edumazet-glaptop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Codel] Fwd: Re: "Controlling Queue Delay" article...
X-BeenThere: codel@lists.bufferbloat.net
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: CoDel AQM discussions <codel.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/codel>
List-Post: <mailto:codel@lists.bufferbloat.net>
List-Help: <mailto:codel-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/codel>,
	<mailto:codel-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 08 May 2012 14:47:11 -0000

On 05/08/2012 10:38 AM, Eric Dumazet wrote:
Let's try to keep things on list...
                - Jim

> On Mon, 2012-05-07 at 20:06 -0700, Kathleen Nichols wrote:
>> Okay, some more tweaks or fixes. I'm finally going through code slowly
>> and also
>> traces from sims. This fix makes it act more like the code I used to do
>> all those
>> sims. mea culpa, but hey, you guys pushed us, so caveat emptor.
>>
>> in dodqueue:
>>
>> dodeque_result codel_queue_t::dodeque(time_t now)
>> {
>>       dodeque_result r = { 0, queue::deque() };
>>       if (r.p == NULL) {
>>             first_above_time = 0;
>>       } else {
>>             time_t sojourn_time = now - r.p->tstamp;
>>             if (sojourn_time < target) {
>>                   // went below so we'll stay below for at least interval
>>                   first_above_time = 0;
>>             } else {
>>                   if (first_above_time == 0) {
>>                         // just went above from below. if we stay above
>>                         // for at least interval we'll say it's ok to drop
>>                         first_above_time = now + interval;
>>                   } else if (now >= first_above_time && bytes() >=
>> maxpacket) {
>>                         r.ok_to_drop = 1;
>>                   }
>>             }
>>       }
>>       return r;
>> }
>
> Ack, I will change our code to match this.
>
> Thanks
>
>