From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from homiemail-a95.g.dreamhost.com (caiajhbdcaid.dreamhost.com [208.97.132.83]) by huchra.bufferbloat.net (Postfix) with ESMTP id BD21121F1C0 for ; Thu, 11 Jul 2013 09:54:38 -0700 (PDT) Received: from homiemail-a95.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a95.g.dreamhost.com (Postfix) with ESMTP id 361891E069; Thu, 11 Jul 2013 09:54:38 -0700 (PDT) Received: from kmn.local (c-24-6-251-213.hsd1.ca.comcast.net [24.6.251.213]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: nichols@pollere.net) by homiemail-a95.g.dreamhost.com (Postfix) with ESMTPSA id 5715C1E064; Thu, 11 Jul 2013 09:54:37 -0700 (PDT) Message-ID: <51DEE34B.5060003@pollere.com> Date: Thu, 11 Jul 2013 09:54:35 -0700 From: Kathleen Nichols User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eric Dumazet References: <51DED2FF.604@pollere.com> <1373559721.4600.43.camel@edumazet-glaptop> In-Reply-To: <1373559721.4600.43.camel@edumazet-glaptop> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Keith Winstein , "codel@lists.bufferbloat.net" Subject: Re: [Codel] sprout X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 16:54:39 -0000 Yes. I think that's a sort of "application - dependent" bit of code perhaps. Van and I had various discussions about this and put that in with very low bandwidth applications in mind, where some "maximums" might be much smaller than others. On 7/11/13 9:22 AM, Eric Dumazet wrote: > On Thu, 2013-07-11 at 08:45 -0700, Kathleen Nichols wrote: > >> Dave, not completely sure which reservation about maxpacket is in reference. > > Hi Kathleen > > I believe Dave is referring to the fact that we update maxpacket every > time we dequeue a packet, and with GSO packet it makes little sense > because after a while maxpacket is set to ~65535, the limit of the GSO > packet size. > > We might remove this code, and make maxpacket a constant. > > diff --git a/include/net/codel.h b/include/net/codel.h > index 389cf62..470e1ff 100644 > --- a/include/net/codel.h > +++ b/include/net/codel.h > @@ -170,7 +170,7 @@ static void codel_vars_init(struct codel_vars *vars) > > static void codel_stats_init(struct codel_stats *stats) > { > - stats->maxpacket = 256; > + stats->maxpacket = 1500; > } > > /* > @@ -221,9 +221,6 @@ static bool codel_should_drop(const struct sk_buff *skb, > vars->ldelay = now - codel_get_enqueue_time(skb); > sch->qstats.backlog -= qdisc_pkt_len(skb); > > - if (unlikely(qdisc_pkt_len(skb) > stats->maxpacket)) > - stats->maxpacket = qdisc_pkt_len(skb); > - > if (codel_time_before(vars->ldelay, params->target) || > sch->qstats.backlog <= stats->maxpacket) { > /* went below - stay below for at least interval */ > > >