From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 44A323B45A for ; Mon, 18 Apr 2016 01:16:53 -0400 (EDT) Received: by mail-wm0-x22b.google.com with SMTP id v188so102207780wme.1 for ; Sun, 17 Apr 2016 22:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=jqlqPy+8ymbDlMQJy8Cc88uC1tQ65FCmxjswO1j1cME=; b=hOndx0mVD3IpeUYi/IgGTKXi1MxxKTPM2nYdNT+KIeE49oH9F70XNiQY9aH1lpBmzd Pcu64VV4vAsQI08VqF82Ye28GgNBA83hfq8pxGw1TEddZSge8Y8ZTmlK6E38GbQ4ctQy jZr95U3tNE/20qU/OxdIZeR6axD+rIi++RQRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=jqlqPy+8ymbDlMQJy8Cc88uC1tQ65FCmxjswO1j1cME=; b=PxIPZCIuVD8HqWYN6Z6cSoCiIPqKx4n+/NTfn2oSJnz8oi/+kAiK6vB8Hdt6Cz/5rz 5pjI0Fk3Pc4gZJ3fVodupkhIcDNoWo3gpkA5i8sSDBYuKdWa+FcJhYpGZx+XVwkRCCHf KE/D5SbmHiQC2Y+3WQN+kmmTYQkkoXDcQV5wTL/Z5XwdeEEmlR3hm9732N/DL1mH6eWA LnljWysJS1mUq22QzMPZRCLz0QF6rYlFfdv2QC/hRmoEFT5LHje4NZrJoz34A/EGcvvR +I96a0D4pgml4f7icz61osLG0ccu3Yd0dAnF/Y9793NH7nvwUpUcMz7CD5ikDYlLRRLH Izng== X-Gm-Message-State: AOPr4FU/N2/69cu532iFA74yfJMHNKYVkrbI5l++Ootb2dWPyu+ROr9igvYBr2tkLBBK+JUpuzMo5VmyUjARyQCc4m4zWGVJbxKJLPwV/ltRr/iv7w+P5NCgBojXEMgoakGEC28gIMOjI7LU2KTW432V4Q== MIME-Version: 1.0 X-Received: by 10.194.166.228 with SMTP id zj4mr7421114wjb.83.1460956612312; Sun, 17 Apr 2016 22:16:52 -0700 (PDT) Received: by 10.194.115.3 with HTTP; Sun, 17 Apr 2016 22:16:52 -0700 (PDT) In-Reply-To: <1460845552.2075.28.camel@sipsolutions.net> References: <1459420104-31554-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-3-git-send-email-michal.kazior@tieto.com> <1460845384.2075.27.camel@sipsolutions.net> <1460845552.2075.28.camel@sipsolutions.net> Date: Mon, 18 Apr 2016 07:16:52 +0200 Message-ID: From: Michal Kazior To: Johannes Berg Cc: linux-wireless , Dave Taht , make-wifi-fast@lists.bufferbloat.net, codel@lists.bufferbloat.net, Avery Pennarun Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-DomainID: tieto.com Subject: Re: [Codel] [PATCHv3 2/5] mac80211: implement fair queueing per txq X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 05:16:53 -0000 On 17 April 2016 at 00:25, Johannes Berg wrote: > On Sun, 2016-04-17 at 00:23 +0200, Johannes Berg wrote: >> On Thu, 2016-04-14 at 14:18 +0200, Michal Kazior wrote: >> > >> > >> > +++ b/net/mac80211/fq.h >> > >> Now that you've mostly rewritten it, why keep it in a .h file? >> > > I think I just confused this with codel.h, but still - why a .h file > with all this "real" code, meaning the file can really only be included > once? I guess .h file can give the compiler an opportunity for more optimizations. With .c you would need LTO which I'm not sure if it's available everywhere. Micha=C5=82