From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CA0863B2A0 for ; Fri, 6 May 2016 01:27:13 -0400 (EDT) Received: by mail-wm0-x235.google.com with SMTP id e201so43797482wme.0 for ; Thu, 05 May 2016 22:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=mQzgaGwp8i40/ieIU8Rd59znMHhzxMzGMaPByw2wcw0=; b=Z5P7RVEUD4Zstho5fgz5N47p6RkX127kr8GBGAzhlZMWfRVI1V5zAJPyFnvW6EqG62 4PZDBGozuKE0fQk+F1w2S2QurtCQ1yk2DM3gA8jYMaqaywrVmsJJjPVxVr5AB3c3ysxV ty5RW8ZOGWf5JwyxUVgwmP/Uql2txfa++Dl/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=mQzgaGwp8i40/ieIU8Rd59znMHhzxMzGMaPByw2wcw0=; b=QXoQJBywWANON3U3doVTQ1+GgDFb8FezUE7ETCoNNsZX8xAJDjk6eWcj1STvS0GjEV hMXEEkbZwx2BoDbYWb+XBFMb8Y0EoaAJ6vCgmAjo5tzrAmlCRTA8pNsEoMH1q6fSkVah eQl82UeHzQ38J2siCx+kAPzfQNxV1Ycb2JhC0ubwl6ReZy1x66Y9wTzi1ss796SCACm4 HGp7vu515QfPGlikfbIbY3ae4p3dAsk1WwPokrUKQzE+7GswqIyRqL57vFhSIA1BHMEN f5AChXZkP1OTu+kgCQTWisAexi9dmd3ZnfwgPS638zIFpNnag4P8pJFFeRIaKKrpQZAY Roxg== X-Gm-Message-State: AOPr4FWdkhbANF4Ysp5YR3fNpg7Wwref9YKDOGJPavs+bOB3fcrJDD2P0hETseQdOG2F6JYGlPo0U8/MLkwKiSz8ufrVPcuTPZg9FqSg7Oq3N2qRYprr+A8h87UajrGRnCPXAzMDJgw8zLkXTaXNwfNvuw== MIME-Version: 1.0 X-Received: by 10.194.171.194 with SMTP id aw2mr20464483wjc.113.1462512432520; Thu, 05 May 2016 22:27:12 -0700 (PDT) Received: by 10.194.65.6 with HTTP; Thu, 5 May 2016 22:27:12 -0700 (PDT) In-Reply-To: References: <1460636302-31161-1-git-send-email-michal.kazior@tieto.com> <1462446039-1070-1-git-send-email-michal.kazior@tieto.com> <1462446039-1070-6-git-send-email-michal.kazior@tieto.com> Date: Fri, 6 May 2016 07:27:12 +0200 Message-ID: From: Michal Kazior To: Dave Taht Cc: linux-wireless , Johannes Berg , make-wifi-fast@lists.bufferbloat.net, "codel@lists.bufferbloat.net" , Avery Pennarun Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-DomainID: tieto.com Subject: Re: [Codel] [PATCHv4 5/5] mac80211: add debug knobs for codel X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 05:27:13 -0000 On 5 May 2016 at 17:21, Dave Taht wrote: > On Thu, May 5, 2016 at 4:00 AM, Michal Kazior w= rote: >> This adds a few debugfs entries to make it easier >> to test, debug and experiment. > > I might argue in favor of moving all these (inc the fq ones) into > their own dir, maybe "aqm" or "sqm". > > The mixture of read only stats and configuration vars is a bit confusing. > > Also in my testing of the previous patch, actually seeing the stats > get updated seemed to be highly async or inaccurate. For example, it > was obvious from the captures themselves that codel_ce_mark-ing was > happening, but the actual numbers out of wack with the mark seen or > fq_backlog seen. (I can go back to revisit this) That's kind of expected since all of these bits are exposed as separate debugfs entries/files. To avoid that it'd be necessary to provide a single debugfs entry/file whose contents are generated on open() while holding local->fq.lock. But then you could argue it should contain all per-sta-tid info as well (backlog, flows, drops) as well instead of having them in netdev*/stations/*/txqs. Hmm.. Micha=C5=82