From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E98EA3B328 for ; Mon, 18 Apr 2016 01:39:17 -0400 (EDT) Received: by mail-wm0-x233.google.com with SMTP id u206so106692624wme.1 for ; Sun, 17 Apr 2016 22:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=xZpAJXo2Cv7TrrwHR9bkGq7ZONHBYVCCDzR3/sJ6DdQ=; b=DY9hHdn2cC0rHcTveRfQtePupyYJwDlEQciey2AMrmOiSsVrQbYFLqkh9wqwICdK9K X4j4sH+Yb/iLLnfYX5o2RGOluXV5FWnQuEhkmn7A/pcm0bRS80K0QpH6A0EyPlfZRHdN TrS+XiBoyzHfxO8PX+PWBLSCuAffXBfcWyOoc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=xZpAJXo2Cv7TrrwHR9bkGq7ZONHBYVCCDzR3/sJ6DdQ=; b=bDl946Tg0UEV/InUjc0QZCWOHp0WWOk7IZLOX9PaGshCVrLUCLm4nbXCB0Wta5frxr DCwwTTzxu+0KBY/fLMKi15OUQ/ANYYmVnfMvJKnfWidQXehTddWphLJsSDPryE8nVEYn RaSuxmUXhem/WG7HfT+vRKUNvZhXcohaqdNAcDMZacb0DK0fE5phzoKtlk+41kLnmnOA +YTLfU/sGo4Hn7QumH4I2XewPcChJynaDzd9eskULBD3jjfZvTY5aY36HeLO/p6gpFQT kkZsEOS4bD45tF3ECqiIe7OgSvQFalujej5TcdfP+k7iS2BshXsSJjYOJmAp7f3+Aedk JCGQ== X-Gm-Message-State: AOPr4FWVEd2dmisIJECiTB4JIqUtKXERqQ3CbCADjzcWLiy41vYG1gvLttkLlp47ig7CLwqCBeHOWSvR5B7nzUZQqMCwGM1J8ZcNNyInxr4+EJ17PTawuC1ZH4jWVdgZawLNXkZqq69k19c82NY8Lhyixw== MIME-Version: 1.0 X-Received: by 10.28.45.212 with SMTP id t203mr16713716wmt.71.1460957956795; Sun, 17 Apr 2016 22:39:16 -0700 (PDT) Received: by 10.194.115.3 with HTTP; Sun, 17 Apr 2016 22:39:16 -0700 (PDT) In-Reply-To: <1460845267.2075.26.camel@sipsolutions.net> References: <1459420104-31554-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-2-git-send-email-michal.kazior@tieto.com> <1460845267.2075.26.camel@sipsolutions.net> Date: Mon, 18 Apr 2016 07:39:16 +0200 Message-ID: From: Michal Kazior To: Johannes Berg Cc: linux-wireless , Dave Taht , make-wifi-fast@lists.bufferbloat.net, codel@lists.bufferbloat.net, Avery Pennarun Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-DomainID: tieto.com Subject: Re: [Codel] [PATCHv3 1/5] mac80211: skip netdev queue control with software queuing X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 05:39:18 -0000 On 17 April 2016 at 00:21, Johannes Berg wrote: >> +static void ieee80211_txq_enqueue(struct ieee80211_local *local, >> + struct txq_info *txqi, >> + struct sk_buff *skb) >> +{ >> + lockdep_assert_held(&txqi->queue.lock); > [...] >> + atomic_inc(&local->num_tx_queued); > > This global kinda bothers me - anything we can do about removing it? I don't think so. Re-counting via sta/vif/txq iteration every time is rather a bad idea. FWIW This is removed by the "fq" patch. The main purpose of taildrop patch is to make some comparisons easier. > We obviously didn't have it now - just one (even bigger limit!) per > queue, so that's 4000 frames default per interface ... now you're down > to 512 for the entire hardware. Perhaps keeping it per interface at > least gets away the worst of the contention here? The default qdisc limits were arguably already too big anyway. Nevertheless it makes sense to have the 512 limit per interface instead of per radio. I'll move num_tx_queued to sdata. Micha=C5=82