From: Dave Taht <dave.taht@gmail.com>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: cake@lists.bufferbloat.net,
"codel@lists.bufferbloat.net" <codel@lists.bufferbloat.net>,
bloat <bloat@lists.bufferbloat.net>
Subject: Re: [Codel] [Cake] Today's cake
Date: Tue, 16 Jun 2015 23:16:27 -0700 [thread overview]
Message-ID: <CAA93jw4LrZ+oPExKtoxj6ufqZiFxT09J=tPv49_DFe_5shU6Gg@mail.gmail.com> (raw)
In-Reply-To: <00270BE3-4932-4294-8917-8A9C2B462FCF@gmail.com>
Just when I thought it was safe to flash a router. Honestly. Your
email landed not less than 5 seconds after I finished a build.
On Tue, Jun 16, 2015 at 10:49 PM, Jonathan Morton <chromatix99@gmail.com> wrote:
> I just put in three quite small tweaks to cake:
>
> 1) Codel now has a saturating increment for count, rather than a wrapping one.
>
> 2) The active flow counter is now an atomic-access variable. This is really just an abundance of caution.
It is not clear to me if this is needed, either.
> 3) The overload drop routine should now be somewhat more efficient in most cases, since it iterates over the active flows rather than the entire array. I haven’t measured how much of a difference it makes in practice, but it should be positive.
I was thinking that tracking the fattest 3 or so flows would suffice,
there would be constant overhead in keeping that statistic handy and
correct but constant overhead on figuring out where to drop on
overload, also.
>
> Point 1 turns out to matter rather a lot under unresponsive loads, given that count is only 16 bits.
>
> The “50 up 1 down asymmetric” test now produces the desired results for the download stream *without* the need to prioritise the acks; Codel now reaches a steady-ish state where it drops enough of them to keep everything moving, and this leaves more bandwidth in the up direction for the 50 streams.
>
> The version of that test with a prioritised download stream reveals that quite a lot of drops (as well as marks) are still occurring in the 50 streams. This, to my mind, is a sign of too much aggression in the switch from marking to dropping, but I need to work out the numbers to be more confident about adjusting that.
k. What bandwidth?
I still disagree with you on count/2 because you are trying to hit the
next harmonic, and agree with you that count-1 is unstable, but I will
try to get some data instead.
>
> - Jonathan Morton
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
--
Dave Täht
What will it take to vastly improve wifi for everyone?
https://plus.google.com/u/0/explore/makewififast
next prev parent reply other threads:[~2015-06-17 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 5:49 [Codel] " Jonathan Morton
2015-06-17 6:16 ` Dave Taht [this message]
2015-06-17 6:25 ` [Codel] [Cake] " Jonathan Morton
2015-06-18 14:31 ` [Codel] [Bloat] " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA93jw4LrZ+oPExKtoxj6ufqZiFxT09J=tPv49_DFe_5shU6Gg@mail.gmail.com' \
--to=dave.taht@gmail.com \
--cc=bloat@lists.bufferbloat.net \
--cc=cake@lists.bufferbloat.net \
--cc=chromatix99@gmail.com \
--cc=codel@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox