From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 421203CB37 for ; Sat, 14 Oct 2023 14:50:23 -0400 (EDT) Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3b2b1ad7ee6so1003467b6e.2 for ; Sat, 14 Oct 2023 11:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697309422; x=1697914222; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h3HM+VYGq2UXhiWHYPUnTAMF77p2ZDY0vjVXkwukr9Q=; b=N9vvypzxUMHqWi1CpXaid1Ik4tzGXhHzPRZpbQGIQtC9jPO7WxzBWOk4EspAmAUazk wORk5+jQYWYEZAZyFw/qTdZx/CsXp5QVBB+nxlDWfTEpXGAih42fPm+1hxf9H8ZNF9Ts 0kP/XHWZmqlcQKwOS0YAHpf/lZ8dh3ofPsDJsMt2np/M0+nGxASpHoqOIjNSd3drRRCd h76IW3ND1Z4YvWjz4T5IM26wybMF3djoOgDKzbeYkfe27uzo22OyJsHZDWjK9nTSpHic Rs8w+D2uLPMzbZ+Oe+Q+jx7RZ7zSAJQ4tqHvFp9t7GX/+A0PSIBZ8CwTB6FdyQJtqDrA joWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697309422; x=1697914222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h3HM+VYGq2UXhiWHYPUnTAMF77p2ZDY0vjVXkwukr9Q=; b=iVdj6oEtiEcZOQtR0FQ5MfqFONqvBlhLb88sV641+PxCFsNs2qCJdbansJ6FKzRWHR suWpJwl6/KNUcfp3S5r0MVIvwGow6J4vo9C0gprupw2PNqc/qo9/D9pcHoreZ6x9HfXW PIdQlUOkMyCgenh7pcPNRMe1xdtsM8GR+VOkBBJ8Oi6AW8jqe7Y/CX+TJEZBz2hjAQMz zexkSZKdqaCizBnDBi8xUFMnc24lMStbgiVAr8EiB1uR9pShbbGdZSHMH0253bMS8MTw bMT+4ZGT2bcc8WXpycPoUrbM/NtBZ8ovn5p9QI6gUkdteNOz0RM2sbUV9WyXQzN7v6NP BTCw== X-Gm-Message-State: AOJu0Yx4nSnoFA/wX+LrlY6HKKNC/V9NFj3+jDNVVnvI+MCMt2oEYLwK +PaOg9093W2CuOa739MBVDquEvTgf/8aaUKQ3cs= X-Google-Smtp-Source: AGHT+IHt3zdMfnyCJkEFwSc2UiBb7GQf/EmMFkp7Ck3FDnVBxTAs/myKgNN2FDXe6okz9sSJSQ+ufk1PFB3FswpuxU4= X-Received: by 2002:a05:6808:1b10:b0:3af:a0bd:45c3 with SMTP id bx16-20020a0568081b1000b003afa0bd45c3mr37868353oib.20.1697309422316; Sat, 14 Oct 2023 11:50:22 -0700 (PDT) MIME-Version: 1.0 References: <3E02B7F5-D0C6-4C33-AFA9-30A2E54B155F@gmail.com> In-Reply-To: <3E02B7F5-D0C6-4C33-AFA9-30A2E54B155F@gmail.com> From: Dave Taht Date: Sat, 14 Oct 2023 11:50:09 -0700 Message-ID: To: Jonathan Morton Cc: codel@lists.bufferbloat.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Codel] fq_"codel" in apple's gear X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Oct 2023 18:50:23 -0000 On Sat, Oct 14, 2023 at 11:17=E2=80=AFAM Jonathan Morton wrote: > > > On 14 Oct, 2023, at 8:23 pm, Dave Taht wrote: > > > > I would really like someone with a fresh set of eyeballs to review the > > "codel" portion of apple's latest code drop here: > > > > https://www.linkedin.com/feed/update/urn:li:activity:711896969498793574= 4/ > > So far as I can tell, it still implements DRR++ (with a comment referenci= ng RFC-8290), but not Codel (there's also no comment referencing RFC-8289).= There's at least one function for handling ECN which is simply not called= , at least not in that source file. Thank you for summoning the gumption to look again. I was having blood pressure problems. > In fact, I looked in the header to see where an ECN mark counter was defi= ned. It is referenced in essentially three places: the definition, an ext= raction for reporting to userspace, and an increment - in a function implem= enting L4S marking, not Codel. > > A similar counter for "early dropped" packets is incremented only when pa= ckets have to be dropped in an emergency because the queue is *full*. That= 's the other counter I would expect to be touched by an AQM implementation. Yep. I had run some tests then and saw the rtts climbing alarmingly, while polling their stack and only seeing drops in big bursty batches, total resets of the tcp flow, and so on. > So, no tangible improvement that I can find easily. > > - Jonathan Morton --=20 Oct 30: https://netdevconf.info/0x17/news/the-maestro-and-the-music-bof.htm= l Dave T=C3=A4ht CSO, LibreQos