From: Dave Taht <dave.taht@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: codel@lists.bufferbloat.net, "Dave Täht" <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [RFC PATCH] Codel: Enable packet drop with ECN-marked packets on a threshold
Date: Sun, 17 Jun 2012 23:01:48 -0400 [thread overview]
Message-ID: <CAA93jw5cw3epqC0wHdkF3Wj2vjt5yGkZOQyHKsqKo6k+67aSjg@mail.gmail.com> (raw)
In-Reply-To: <1339988306.7491.306.camel@edumazet-glaptop>
On Sun, Jun 17, 2012 at 10:58 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Sun, 2012-06-17 at 22:40 -0400, Dave Taht wrote:
>> On Sun, Jun 17, 2012 at 10:17 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> > if (A && B && C)
>> >
>> > Even if (C) is false, but A is true, B is evaluated.
>>
>> A is always true (or always false)
>> B in this case is usually false except on the kinds of ECN-heavy
>> workloads that exposed this issue
>> and C is probably higher overhead than A or B
>>
>> So a better conditional is possible...
>
> Not only better, but _correct_ ;)
>
> To have a chance to be correct, your patch should have been :
>
>
> if (params->ecn &&
> vars->ldelay <= 2 * params->target &&
> INET_ECN_set_ce(skb))
>
> Because INET_ECN_set_ce(skb) is _doing_ ecn marking, and returns true is
> ECN was successfully applied to the packet.
heh. OK, point taken, patch corrected here. I am averaging one bug per
two lines of code...
--
Dave Täht
SKYPE: davetaht
http://ronsravings.blogspot.com/
next prev parent reply other threads:[~2012-06-18 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 22:30 Dave Täht
2012-06-18 2:17 ` Eric Dumazet
2012-06-18 2:40 ` Dave Taht
2012-06-18 2:58 ` Eric Dumazet
2012-06-18 3:01 ` Dave Taht [this message]
2012-06-18 3:10 ` Eric Dumazet
2012-06-18 3:21 ` Dave Taht
2012-06-18 3:50 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA93jw5cw3epqC0wHdkF3Wj2vjt5yGkZOQyHKsqKo6k+67aSjg@mail.gmail.com \
--to=dave.taht@gmail.com \
--cc=codel@lists.bufferbloat.net \
--cc=dave.taht@bufferbloat.net \
--cc=eric.dumazet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox