CoDel AQM discussions
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: codel@lists.bufferbloat.net
Subject: [Codel] Fwd: [PATCH v3 net-next 1/7] net: skb_drop_reason: add document for drop reasons
Date: Thu, 10 Feb 2022 08:55:15 -0800	[thread overview]
Message-ID: <CAA93jw5kR=fA-O_gfLSgO_OcOHFf9jbHon=UwMrURcCJjtHYTQ@mail.gmail.com> (raw)
In-Reply-To: <20220128073319.1017084-2-imagedong@tencent.com>

is this concept useful to us? (e.g. SKB_DROP_REASON_CONGESTION)

---------- Forwarded message ---------
From: <menglong8.dong@gmail.com>
Date: Sat, Jan 29, 2022 at 7:54 PM
Subject: [PATCH v3 net-next 1/7] net: skb_drop_reason: add document
for drop reasons
To: <dsahern@kernel.org>, <kuba@kernel.org>
Cc: <rostedt@goodmis.org>, <mingo@redhat.com>, <davem@davemloft.net>,
<yoshfuji@linux-ipv6.org>, <pablo@netfilter.org>,
<kadlec@netfilter.org>, <fw@strlen.de>, <imagedong@tencent.com>,
<edumazet@google.com>, <alobakin@pm.me>, <paulb@nvidia.com>,
<keescook@chromium.org>, <talalahmad@google.com>,
<haokexin@gmail.com>, <memxor@gmail.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
<cong.wang@bytedance.com>, <mengensun@tencent.com>


From: Menglong Dong <imagedong@tencent.com>

Add document for following existing drop reasons:

SKB_DROP_REASON_NOT_SPECIFIED
SKB_DROP_REASON_NO_SOCKET
SKB_DROP_REASON_PKT_TOO_SMALL
SKB_DROP_REASON_TCP_CSUM
SKB_DROP_REASON_SOCKET_FILTER
SKB_DROP_REASON_UDP_CSUM

Signed-off-by: Menglong Dong <imagedong@tencent.com>
---
 include/linux/skbuff.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 8a636e678902..5c5615a487e7 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -314,12 +314,12 @@ struct sk_buff;
  * used to translate the reason to string.
  */
 enum skb_drop_reason {
-       SKB_DROP_REASON_NOT_SPECIFIED,
-       SKB_DROP_REASON_NO_SOCKET,
-       SKB_DROP_REASON_PKT_TOO_SMALL,
-       SKB_DROP_REASON_TCP_CSUM,
-       SKB_DROP_REASON_SOCKET_FILTER,
-       SKB_DROP_REASON_UDP_CSUM,
+       SKB_DROP_REASON_NOT_SPECIFIED,  /* drop reason is not specified */
+       SKB_DROP_REASON_NO_SOCKET,      /* socket not found */
+       SKB_DROP_REASON_PKT_TOO_SMALL,  /* packet size is too small */
+       SKB_DROP_REASON_TCP_CSUM,       /* TCP checksum error */
+       SKB_DROP_REASON_SOCKET_FILTER,  /* dropped by socket filter */
+       SKB_DROP_REASON_UDP_CSUM,       /* UDP checksum error */
        SKB_DROP_REASON_MAX,
 };

--
2.34.1



-- 
I tried to build a better future, a few times:
https://wayforward.archive.org/?site=https%3A%2F%2Fwww.icei.org

Dave Täht CEO, TekLibre, LLC

           reply	other threads:[~2022-02-10 16:55 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220128073319.1017084-2-imagedong@tencent.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA93jw5kR=fA-O_gfLSgO_OcOHFf9jbHon=UwMrURcCJjtHYTQ@mail.gmail.com' \
    --to=dave.taht@gmail.com \
    --cc=codel@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox