From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 63578202213 for ; Sun, 6 May 2012 22:52:20 -0700 (PDT) Received: by wibhn14 with SMTP id hn14so2554091wib.10 for ; Sun, 06 May 2012 22:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=d/neKCnTwWxL0jitSYjOI6mwz0S1w91e8gru1ziVm6w=; b=eFNtcbwmQllF681agMiJBPhy84xJ/pNUZvICPDU7pY4yrn8J1bdpAT9zN03WyDN5IV fCdfXK3sUX6T+21Z8ue/SsZlsFZX2AY0LO1iz/TQlZZt125QQj3iUnUOPppTrgWC1qBt KCiZuURbqBaKNPWQv6ZEh6d15COtYN0XA4WxWNXrW8fcO5kKrviEfEub2VoK6yPQLv1F lCPZihLdcV4DKnhTupGUZ8BvzLScDIw/Im+RlDvdh8MdAwq7YyZIHWuYZv1KHikOyS1O 8WZqYRDi/wAumniQXb+r9ZwsldRGMlLrlwUryxSCxWiwThmyRT2i3B+iNvdSFmGlDO+7 uE2Q== MIME-Version: 1.0 Received: by 10.216.198.14 with SMTP id u14mr251658wen.12.1336369938380; Sun, 06 May 2012 22:52:18 -0700 (PDT) Received: by 10.223.112.66 with HTTP; Sun, 6 May 2012 22:52:18 -0700 (PDT) In-Reply-To: <1336369834.3752.2234.camel@edumazet-glaptop> References: <1336368957-17586-1-git-send-email-dave.taht@bufferbloat.net> <1336369834.3752.2234.camel@edumazet-glaptop> Date: Sun, 6 May 2012 22:52:18 -0700 Message-ID: From: Dave Taht To: Eric Dumazet Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: codel@lists.bufferbloat.net, =?ISO-8859-1?Q?Dave_T=E4ht?= Subject: Re: [Codel] [PATCH v9] codel: Controlled Delay AQM X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2012 05:52:20 -0000 On Sun, May 6, 2012 at 10:50 PM, Eric Dumazet wrot= e: > On Sun, 2012-05-06 at 22:35 -0700, Dave T=E4ht wrote: >> This version (9) adds support for various forms of decrease in s3, >> in the form of the module parameters gentle and decrease_method. >> >> It defaults to the algorithm as described in the original presentation. >> >> v1: Original implementation - Dave Taht >> v2: Working code - Corrections for ktime - Dave Taht >> v3: 32 bit support and port to net-next - Eric Dumazet >> v4: 16 bit precision for inv sqrt and cache - Dave Taht >> v5: Kernel cleanup and full precision - Eric Dumazet >> v6: Dump Stats support added - Eric Dumazet >> v7: Complete rewrite for u32 values - Eric Dumazet >> v8: Stats and timing added, 64 bit prescale improved - Eric Dumazet >> v9: debated functionality moved to isolated routine - Dave Taht >> --- > >> +static u32 gentle =3D 0; >> +static u32 decrease_method =3D 0; >> +module_param(gentle, uint, 0644); >> +module_param(decrease_method, uint, 0644); >> +MODULE_PARM_DESC(gentle,"Gently increment count in massive drop state")= ; >> +MODULE_PARM_DESC(decrease_method,"Various means of decreasing count"); > > Hey, thats absolutely forbidden. > > Just add new TCA_CODEL_xxx knobs to control things with tc, for each > qdisc, and not globally on the machine. > I regard this addition as a debugging tool, not api functionality, at least at present... > > > _______________________________________________ > Codel mailing list > Codel@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/codel --=20 Dave T=E4ht SKYPE: davetaht US Tel: 1-239-829-5608 http://www.bufferbloat.net