From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client did not present a certificate) by huchra.bufferbloat.net (Postfix) with ESMTPS id D21B121F0EA; Thu, 30 Aug 2012 19:34:05 -0700 (PDT) Received: by wgbfa7 with SMTP id fa7so1382261wgb.28 for ; Thu, 30 Aug 2012 19:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=OAvoyjNeaTJQoiUFWGTONICjhdE57+JfLhTMz1IocMw=; b=CK1OF9UOIByxO6+hZo9ZKhTEHJYwayzUpizs4rEDVX5Hmot6tRQYfhaLQOH8x4/mCB DlOJChU56t/Y3LRngAfNbbaQTizQw0i0Rb0JAnn8dn/f28gA4OMPy585mfWi88C+Sipk JNKyMwcI5qONn/tHNA7vmbyXa+SDFotQsAHT3lyBwMcmDXJEwgy0h0hNvp9DbOjN7eFv KysPLUCJkKvXSOAbAFyvSd19MTpsLlki6A/I0NU/aQpjS3qHguUrnKeBSCiPnyAvRUJj IsN9V3fbL/l3mo9MDzhwItmMLUgk/8k05v9zl8Sw+So32ytTSNMSJQdr3gRY1PeKnRMb A4MQ== MIME-Version: 1.0 Received: by 10.216.71.82 with SMTP id q60mr4213847wed.64.1346380443919; Thu, 30 Aug 2012 19:34:03 -0700 (PDT) Received: by 10.223.159.134 with HTTP; Thu, 30 Aug 2012 19:34:03 -0700 (PDT) In-Reply-To: <1346377256.2586.37.camel@edumazet-glaptop> References: <1346367998.2586.33.camel@edumazet-glaptop> <1346377256.2586.37.camel@edumazet-glaptop> Date: Thu, 30 Aug 2012 19:34:03 -0700 Message-ID: From: Dave Taht To: Eric Dumazet Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: codel@lists.bufferbloat.net, cerowrt-devel@lists.bufferbloat.net Subject: Re: [Codel] better mixing in fq_codel X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2012 02:34:06 -0000 On Thu, Aug 30, 2012 at 6:40 PM, Eric Dumazet wrot= e: > On Thu, 2012-08-30 at 16:19 -0700, Dave Taht wrote: > >> In that case it will deliver 3 acks in a row from >> stream A, and then 3 acks in stream B, in the linux 3.5 version, and >> push the the 1500 byte packet from my example to the old flows queue - > > Nope, the 1500 byte packet will be sent as normal (we obviously cant > split a packet). If its the first packet (new flow), there wont be any > penalty. > >> instead of delivering A 1 ack, B 1 ack, push the C 1500 byte packet to >> the old flows queue, then deliver A,B,A,B,A,B, A, A, A etc (and note >> with more flows mixing gets better) as I just proposed. > > Try to change quantum, and it will just work out of the box. I think, eric, that you missed this portion of the idea, and that I mis-commented it, and worse, overstated the effect of what I was trying to do while watching it crash... ...and seeing through the dust and clouds... off in the distance... the desirable behavior I'd been aiming for. ... in fq_codel_enqueue... flow->deficit =3D min(q->quantum, qdisc_pkt_len(skb)); // put only 1 packet into the new flow queue unless it's more than quantum (in which case it too will be kicked to old flows) --=20 Dave T=E4ht http://www.bufferbloat.net/projects/cerowrt/wiki - "3.3.8-17 is out with fq_codel!"