Re: [Codel] [PATCH 1/2] codel: Controlled Delay AQM

[Dave Taht <dave.taht@gmail.com>]

On Mon, May 7, 2012 at 10:34 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Mon, 2012-05-07 at 10:27 -0700, Rick Jones wrote:
>
>>
>> I don't wish to rathole, and someone may want to declare Bikeshed! but
>> the target audience of the paper is a bit different from the Linux
>> system administrator base yes?  If a parameter name enhancement makes
>> something more clear to an administrator is it really a bad thing to
>> have a name that is not a strict duplicate of the paper's?
>>
>> rick
>
> I dont know, we have no precedence in linux for 'target' and 'interval'
>
> So picking the codel words seems ok

I like short names from a readability perspective. I'm not big on underscores,
they are hard to see. (I'm getting old)

I note that codel is intended to run in most cases without any parameters.

limit: used elsewhere in linux for a packet limit. A packet limit is there for
practical reasons, shrinking the queue has overhead. However, codel will
run just fine with infinite queue (yea!), and I suspect the default
1000 is too small
on 10GigE. If there was a way to autotune it based on the underlying
device, that would be good.

target: At the moment this is a knob because 5ms is an eternity at 10GigE
interval: Same reason

I'm not big on changing these from the paper, nor on _s, nor on length.
However, I'm open to further discussion.

maxpacket: really confusing usages, so I went with minbytes which is explicit

Any objections?

(min was overloaded with red's usage, so I felt that would be confusing, too)

ecn:

ecn was not in the paper (and it's working well) and I'd like to live
in a world where ecn was the default. I think. Others disagree.

so perhaps ecn and noecn? And ecn be the default (after some serious testing?)

Parameterless is a good goal.

>
>
>
> _______________________________________________
> Codel mailing list
> Codel@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/codel



-- 
Dave Täht
SKYPE: davetaht
US Tel: 1-239-829-5608
http://www.bufferbloat.net