CoDel AQM discussions
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: codel@lists.bufferbloat.net, "Dave Täht" <dave.taht@bufferbloat.net>
Subject: Re: [Codel] [RFCv2 PATCH] iproute2: Add ecn_target option to codel and fq_codel
Date: Mon, 25 Jun 2012 07:54:53 -0700	[thread overview]
Message-ID: <CAA93jw7QhSm5maZ6eN9BGnzu7F+G2JCvD9wNUOg8HzWHk1y9ig@mail.gmail.com> (raw)
In-Reply-To: <1340602168.23933.22.camel@edumazet-glaptop>

On Sun, Jun 24, 2012 at 10:29 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Sun, 2012-06-24 at 22:00 -0700, Dave Täht wrote:
>> From: Dave Taht <dave.taht@bufferbloat.net>
>>
>> ECN was not part of the original codel design and adding support
>> for it revealed problems in two areas. 1) ECN can be gamed.
>> 2) Dropping packets under overload more rapidly frees up
>> bandwidth than marking packets.
>>
>> Two possible scenarios of use - on egress from a network,
>> ecn_target could be set low, to drop more often, to
>> ensure lowest latency for other packets.
>>
>> On ingress, it could be set high to mark packets more often,
>> to lower data loss while still signalling the end application
>> that bandwidth is a problem.
>>
>> ecn_target is not engaged until after codel enters a dropping
>> state overall.
>
> I would suggest 'drop_above' instead of ecn_target, since its quite
> different than the 'target'

OK. I will respin this after resolving the issue I raised in the previous patch
comment (just switch ecn to being an int?), and do some testing. As noted
I was (de)impressed at the amount of ecn drops I had with it set to 2*target
on pure ecn enabled streams. In one test it was 95% drops...

And I'm still open to saner approaches. Another one might be to at graduated
levels drop big packets down to smaller ones.

> (And dont display/output it if ecn is not set, no need to confuse users
> who didn't enable ecn on CoDel)
>
>
>
> _______________________________________________
> Codel mailing list
> Codel@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/codel



-- 
Dave Täht
http://www.bufferbloat.net/projects/cerowrt/wiki - "3.3.8-6 is out
with fq_codel!"

      reply	other threads:[~2012-06-25 14:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25  5:00 Dave Täht
2012-06-25  5:00 ` [Codel] [RFCv2 PATCH] codel: add ecn_target for when to drop rather than mark ecn packets Dave Täht
2012-06-25  5:22   ` Eric Dumazet
2012-06-25 14:50     ` Dave Taht
2012-06-25 15:20       ` Eric Dumazet
2012-06-25 15:30         ` Dave Taht
2012-06-25 15:45           ` Eric Dumazet
2012-06-25 17:48             ` Jonathan Morton
2012-06-25 18:25               ` Dave Taht
2012-06-25 18:51                 ` Eric Dumazet
2012-06-25  5:24 ` [Codel] [RFCv2 PATCH] iproute2: Add ecn_target option to codel and fq_codel Eric Dumazet
2012-06-25  5:29 ` Eric Dumazet
2012-06-25 14:54   ` Dave Taht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw7QhSm5maZ6eN9BGnzu7F+G2JCvD9wNUOg8HzWHk1y9ig@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=codel@lists.bufferbloat.net \
    --cc=dave.taht@bufferbloat.net \
    --cc=eric.dumazet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox