From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x242.google.com (mail-ob0-x242.google.com [IPv6:2607:f8b0:4003:c01::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 401D53B260; Thu, 5 May 2016 10:32:36 -0400 (EDT) Received: by mail-ob0-x242.google.com with SMTP id ds10so5092230obb.3; Thu, 05 May 2016 07:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=e7/mUu9sA8/BWdn2F49MjUqwZESsdC99vVr6XESGrto=; b=qd+J+ycnT2RyL8OjbB5D5Sx/9WtvdZNDWH44fj96PzD/oG6WXIU47OeHgVyeZ1GWRa SYgBaHSxu5MX9E8FDUsyV1+VvwHoa9c9hK/fo30+PsCKui/Yli6gAveAgt1b3F4hVXiW 7JnIaD2y8Of8g3JJ/YBZ033N6TQjT4v9QT1iXxZnesTtkzAQFvqLEbjdM+3yyIrXV98K h9Kz+uCmimbhm7kxE0xoH8lLD30UFLoHSkbHxq77pivSQtYOIUyaJasST/sxusMJH2J7 qMTTkBcPMQzJTOCBkSiBVbYtxHyB7Y28uu1aD/uSKY/DUuEaE1pJ4kbFBtbcrSAWhZq0 KAVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=e7/mUu9sA8/BWdn2F49MjUqwZESsdC99vVr6XESGrto=; b=WqDWCUTgyhS3WA+Y499Xz/c04LU0nWORHyAqbgDgsACuseTOtpF5Fnb7OM5Bk3JvnC vduFr9CadrXvL9i7dCge38It2K454fuBMWhNYQsQ5IPzLBsawG2AWFrpdoEk3/IDiXVd TNOYvottyY0k5xiPUTHceQoTIjrmyxWmF7UpVJa/QeONFDwVp8l4uQMPDk3sItKZszgV bCfSLAg7n+ZJ7KdEaCh3G6VFiIMQZ72F8n9cWwddFMDikMA6L9iQzbzZjUOT9X+9Tf5U woODQK2WHMdWxZ3BsYn4ny57kL9nCaEJtP2uqNH7ybtwNcWMonEjfQtGMUFVgrFqWH1s 0E7A== X-Gm-Message-State: AOPr4FUk9Myw+8jpgmmZu1rHbqjGuN+etzADMnIWk5XMVC97dl7MNYqaz0h2iQZbIMbErRXIfS0nUKv6PwbTAA== MIME-Version: 1.0 X-Received: by 10.60.32.230 with SMTP id m6mr5238540oei.55.1462458754389; Thu, 05 May 2016 07:32:34 -0700 (PDT) Received: by 10.202.252.9 with HTTP; Thu, 5 May 2016 07:32:34 -0700 (PDT) In-Reply-To: References: <1462125592.5535.194.camel@edumazet-glaptop3.roam.corp.google.com> <865DA393-262D-40B6-A9D3-1B978CD5F6C6@gmail.com> <1462128385.5535.200.camel@edumazet-glaptop3.roam.corp.google.com> <1462136140.5535.219.camel@edumazet-glaptop3.roam.corp.google.com> <1462201620.5535.250.camel@edumazet-glaptop3.roam.corp.google.com> <1462205669.5535.254.camel@edumazet-glaptop3.roam.corp.google.com> Date: Thu, 5 May 2016 17:32:34 +0300 Message-ID: From: Roman Yeryomin To: Dave Taht Cc: Eric Dumazet , Jonathan Morton , make-wifi-fast@lists.bufferbloat.net, "codel@lists.bufferbloat.net" , ath10k , Michal Kazior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Codel] fq_codel_drop vs a udp flood X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 14:32:36 -0000 On 2 May 2016 at 20:08, Dave Taht wrote: > On Mon, May 2, 2016 at 9:14 AM, Eric Dumazet wro= te: >> On Mon, 2016-05-02 at 18:43 +0300, Roman Yeryomin wrote: >>> On 2 May 2016 at 18:07, Eric Dumazet wrote: >>> > On Mon, 2016-05-02 at 17:18 +0300, Roman Yeryomin wrote: >>> > >>> >> Imagine you are a video operator, have MacBook Pro, gigabit LAN and >>> >> NAS on ethernet side. You would want to get maximum speed. And >>> >> fq_codel just dropped it down to 550Mbps for TCP (instead of 750Mbps= ) >>> >> and to 30Mbps for UDP (instead of 900Mbps). >>> >> So, again, it looks broken to me. > > The big regression trying to be addressed here is the decades long > increase in wifi overbuffering for slow and normal clients. > > The number that was making me happy was seeing low speed clients > finally have sane behavior: > http://blog.cerowrt.org/post/fq_codel_on_ath10k/ > > I will add your iperf flood test to the testbench. Certainly we don't > want to hurt peak speeds overmuch... but we'd also like to see people > trying traffic at lower speeds. > > Incidentally if you are doing openwrt builds that would be of great help. > >>> > Can you show us your qdisc config ? >>> >>> Which build do you want? Before it broke or after? > > Commit hashes for each would help. commit hashes wouldn't help much, I was reverting patches (see previous emails in this thread). >> >> >> I want to check your qdisc configuration, the one that you used and >> where you had fq_codel performance issues >> >> tc -s -d qdisc > > Not sure it's the qdisc version under test here. ? If it is, I'd be > perversely happy as for the first time ever the wifi layer started > exerting some backpressure on the upper layers of the stack. > > I'm not sure which parts of which patchset are under test here, > either. I saw a few too many patches go by all around, and I am only > just this week able to add ath10k to my test matrix. Commit? > > https://github.com/kazikcz/linux/commits/fqmac-v3.5 has a version of > fq_codel in it (and the underlying driver changes) *at the mac80211 > layer*, not the qdisc layer. It disables the overlying qdisc. It will > need the equivalent new fq_codel_drop logic added to it, that eric > just added, also, to do better on the udp flood test. > > There was a prior branch that did pretty darn well at high speeds, > results I put on that blog post I linked to above - 820Mbps for tcp, > an actual improvement on the baseline test. The current branch is > simpler and did not do as well due in part to not being integrated > with rate control (I think). > > There are pieces dropping in all over, there was a amdsu patch, > another patch on rx/tx, > > > -- > Dave T=C3=A4ht > Let's go make home routers and wifi faster! With better software! > http://blog.cerowrt.org