From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Taht <dave.taht@bufferbloat.net>
Cc: netdev <netdev@vger.kernel.org>, codel@lists.bufferbloat.net
Subject: Re: [Codel] [PATCH 1/2] fq_codel: keep dropped statistic around
Date: Mon, 21 Oct 2013 18:27:11 -0700 [thread overview]
Message-ID: <CAL4Wiio0YThCbT8j92HVn1CmmdvKD=GT30ZtMf=ZvmAj+ZM7Yg@mail.gmail.com> (raw)
In-Reply-To: <1382404797-17239-2-git-send-email-dave.taht@bufferbloat.net>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Oct 21, 2013 6:20 PM, "Dave Taht" <dave.taht@bufferbloat.net> wrote:
>
> Having more accurate dropped information in this qdisc is useful.
>
> Signed-off-by: Dave Taht <dave.taht@bufferbloat.net>
> ---
> net/sched/sch_fq_codel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
> index 5578628..437bc95 100644
> --- a/net/sched/sch_fq_codel.c
> +++ b/net/sched/sch_fq_codel.c
> @@ -193,7 +193,6 @@ static int fq_codel_enqueue(struct sk_buff *skb,
struct Qdisc *sch)
> list_add_tail(&flow->flowchain, &q->new_flows);
> q->new_flow_count++;
> flow->deficit = q->quantum;
> - flow->dropped = 0;
> }
> if (++sch->q.qlen <= sch->limit)
> return NET_XMIT_SUCCESS;
> --
> 1.7.9.5
I am travelling to Edinburgh, so will be short.
Since fqcodel recycles a slot, we need to clear this counter. We do no know
if slot is reused by previous flow or a new flow hashing to same bucket.
[-- Attachment #2: Type: text/html, Size: 1411 bytes --]
next prev parent reply other threads:[~2013-10-22 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 1:19 [Codel] [PATCH 0/2] net-next codel enhancements Dave Taht
2013-10-22 1:19 ` [Codel] [PATCH 1/2] fq_codel: keep dropped statistic around Dave Taht
2013-10-22 1:27 ` Eric Dumazet [this message]
2013-10-22 1:43 ` Dave Taht
2013-10-22 1:19 ` [Codel] [PATCH 2/2] codel: eliminate maxpacket as an inner bound Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL4Wiio0YThCbT8j92HVn1CmmdvKD=GT30ZtMf=ZvmAj+ZM7Yg@mail.gmail.com' \
--to=eric.dumazet@gmail.com \
--cc=codel@lists.bufferbloat.net \
--cc=dave.taht@bufferbloat.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox