From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 1F83B21F0E8 for ; Mon, 21 Oct 2013 18:27:12 -0700 (PDT) Received: by mail-pd0-f179.google.com with SMTP id y10so5432000pdj.10 for ; Mon, 21 Oct 2013 18:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7I+oG910sMMcKjgUvHuQ7e3RwCkOhoBcDzW4Y4jYBvQ=; b=N25UzHPFI5Qn0n0MAnTJyi2KaW4nJOSJA2NtwXF5QGhCb5tnAePjwxHChhr6MzgyWk zhCttXHyjHPN7VjiMnCpULBb2iiwyTZYS6xy4tYqF2oeHeipFINDPaeGnxbVyMYx76Yy Dnp1M22i5QrOHe80zefQ8xhwAtSbSkpdKBW9jgeL/xKAdoQpOegi+ywzIVvph1q3mXU8 nnH0ldLr1YU0YjQ/QCRoLHKCyo8eUpMvxMEGrnPGn06r7RNskF6tBU2Cf093BKr3DkD6 eUL+L9Nbf0g6Uw+plWV7nWcAYnKOZk0Ls5by5dhoOZ/xHceVBozbMiJMHVKEEmhf4+Vl 50bw== MIME-Version: 1.0 X-Received: by 10.66.161.138 with SMTP id xs10mr21086285pab.56.1382405231273; Mon, 21 Oct 2013 18:27:11 -0700 (PDT) Received: by 10.70.7.4 with HTTP; Mon, 21 Oct 2013 18:27:11 -0700 (PDT) Received: by 10.70.7.4 with HTTP; Mon, 21 Oct 2013 18:27:11 -0700 (PDT) In-Reply-To: <1382404797-17239-2-git-send-email-dave.taht@bufferbloat.net> References: <1382404797-17239-1-git-send-email-dave.taht@bufferbloat.net> <1382404797-17239-2-git-send-email-dave.taht@bufferbloat.net> Date: Mon, 21 Oct 2013 18:27:11 -0700 Message-ID: From: Eric Dumazet To: Dave Taht Content-Type: multipart/alternative; boundary=047d7b86e864beec0f04e94a4c04 Cc: netdev , codel@lists.bufferbloat.net Subject: Re: [Codel] [PATCH 1/2] fq_codel: keep dropped statistic around X-BeenThere: codel@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: CoDel AQM discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 01:27:12 -0000 --047d7b86e864beec0f04e94a4c04 Content-Type: text/plain; charset=ISO-8859-1 On Oct 21, 2013 6:20 PM, "Dave Taht" wrote: > > Having more accurate dropped information in this qdisc is useful. > > Signed-off-by: Dave Taht > --- > net/sched/sch_fq_codel.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c > index 5578628..437bc95 100644 > --- a/net/sched/sch_fq_codel.c > +++ b/net/sched/sch_fq_codel.c > @@ -193,7 +193,6 @@ static int fq_codel_enqueue(struct sk_buff *skb, struct Qdisc *sch) > list_add_tail(&flow->flowchain, &q->new_flows); > q->new_flow_count++; > flow->deficit = q->quantum; > - flow->dropped = 0; > } > if (++sch->q.qlen <= sch->limit) > return NET_XMIT_SUCCESS; > -- > 1.7.9.5 I am travelling to Edinburgh, so will be short. Since fqcodel recycles a slot, we need to clear this counter. We do no know if slot is reused by previous flow or a new flow hashing to same bucket. --047d7b86e864beec0f04e94a4c04 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable


On Oct 21, 2013 6:20 PM, "Dave Taht" <dave.taht@bufferbloat.net> wrote:
>
> Having more accurate dropped information in this qdisc is useful.
>
> Signed-off-by: Dave Taht <dave.taht@bufferbloat.net>
> ---
> =A0net/sched/sch_fq_codel.c | =A0 =A01 -
> =A01 file changed, 1 deletion(-)
>
> diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
> index 5578628..437bc95 100644
> --- a/net/sched/sch_fq_codel.c
> +++ b/net/sched/sch_fq_codel.c
> @@ -193,7 +193,6 @@ static int fq_codel_enqueue(struct sk_buff *skb, s= truct Qdisc *sch)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 list_add_tail(&flow->flowchain,= &q->new_flows);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 q->new_flow_count++;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 flow->deficit =3D q->quantum; > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 flow->dropped =3D 0;
> =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 =A0 if (++sch->q.qlen <=3D sch->limit)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return NET_XMIT_SUCCESS;
> --
> 1.7.9.5
I am travelling to Edinburgh, so will be short.

Since fqcodel recycles a slot, we need to clear this counter= . We do no know if slot is reused by previous flow or a new flow hashing to= same bucket.

--047d7b86e864beec0f04e94a4c04--